Implement IBusDaemonControllerDaemonlessImpl.

chromeos/ime/ibus_daemon_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/ime/ibus_daemon_controller.h"
 
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/environment.h"
 #include "base/files/file_path_watcher.h"
@@ skipping 245 matching lines @@
 
   ObserverList<Observer> observers_;
   base::ThreadChecker thread_checker_;
 
   // Used for making callbacks for PostTask.
   base::WeakPtrFactory<IBusDaemonControllerImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(IBusDaemonControllerImpl);
 };
 
-// The stub implementation of IBusDaemonController.
-class IBusDaemonControllerStubImpl : public IBusDaemonController {
+// An implementation of IBusDaemonController without ibus-daemon interaction.
+// Currently this class is used only on linux desktop.
+// TODO(nona): Remove IBusDaemonControlelr this once crbug.com/171351 is fixed.
+class IBusDaemonControllerDaemonlessImpl : public IBusDaemonController {
  public:
-  IBusDaemonControllerStubImpl() {}
-  virtual ~IBusDaemonControllerStubImpl() {}
+  IBusDaemonControllerDaemonlessImpl()
+      : is_started_(false) {}
+  virtual ~IBusDaemonControllerDaemonlessImpl() {}
 
   // IBusDaemonController overrides:
-  virtual void AddObserver(Observer* observer) OVERRIDE {}
-  virtual void RemoveObserver(Observer* observer) OVERRIDE {}
-  virtual bool Start() OVERRIDE { return true; }
-  virtual bool Stop() OVERRIDE { return true; }
+  virtual void AddObserver(Observer* observer) OVERRIDE {
+    observers_.AddObserver(observer);
+  }
+
+  virtual void RemoveObserver(Observer* observer) OVERRIDE {
+    observers_.RemoveObserver(observer);
+  }
+
+  virtual bool Start() OVERRIDE {
+    if (is_started_)
+      return false;
+    DBusThreadManager::Get()->InitIBusBus("dummy address",

[satorux1, 2013/03/11 01:24:29]

The word "dummy" worries me. Please explain why in a comment.

[Seigo Nonaka, 2013/03/11 03:40:27]

Done.

+                                          base::Bind(&base::DoNothing));
+    is_started_ = true;
+    FOR_EACH_OBSERVER(Observer, observers_, OnConnected());
+    return true;
+  }
+  virtual bool Stop() OVERRIDE {
+    if (!is_started_)
+      return false;
+    is_started_ = false;
+    FOR_EACH_OBSERVER(Observer, observers_, OnDisconnected());
+    return true;
+  }
 
  private:
-  DISALLOW_COPY_AND_ASSIGN(IBusDaemonControllerStubImpl);
+  ObserverList<Observer> observers_;
+  bool is_started_;
+  DISALLOW_COPY_AND_ASSIGN(IBusDaemonControllerDaemonlessImpl);
 };
 
 }  // namespace
 
 ///////////////////////////////////////////////////////////////////////////////
 // IBusDaemonController
 
 IBusDaemonController::IBusDaemonController() {
 }
 
 IBusDaemonController::~IBusDaemonController() {
 }
 
 // static
 void IBusDaemonController::Initialize(
     const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner,
     const scoped_refptr<base::SequencedTaskRunner>& file_task_runner) {
   DCHECK(g_ibus_daemon_controller == NULL)
       << "Do not call Initialize function multiple times.";
   if (base::chromeos::IsRunningOnChromeOS()) {
     g_ibus_daemon_controller = new IBusDaemonControllerImpl(ui_task_runner,
                                                             file_task_runner);
   } else {
-    g_ibus_daemon_controller = new IBusDaemonControllerStubImpl();
+    g_ibus_daemon_controller = new IBusDaemonControllerDaemonlessImpl();
   }
 }
 
 // static
 void IBusDaemonController::InitializeForTesting(
     IBusDaemonController* controller_) {
   DCHECK(g_ibus_daemon_controller == NULL);
   DCHECK(controller_);
   g_ibus_daemon_controller = controller_;
 }
 
 // static
 void IBusDaemonController::Shutdown() {
   delete g_ibus_daemon_controller;
   g_ibus_daemon_controller = NULL;
 }
 
 // static
 IBusDaemonController* IBusDaemonController::GetInstance() {
   return g_ibus_daemon_controller;
 }
 
 }  // namespace chromeos