Add skip_canned option to presubmit_support.

Add skip_canned option to presubmit_support.

This will replace the hack in commit-queue/verification/presubmit_shim, and will
be used on the presubmit trybot.

R=maruel@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186922

[iannucci, 2013-03-05 21:27:05]

On 2013/03/05 21:23:36, iannucci wrote:

+vadimsh since he's planning on using this for the upcoming build waterfall.

[M-A Ruel, 2013-03-06 20:39:03]

Need test.

[iannucci, 2013-03-06 23:13:00]

On 2013/03/06 20:39:03, Marc-Antoine Ruel wrote:
> Need test.

I'm not sure how to test this effectively... The existing tests for Main
completely mock out the actual presubmit logic. If I simply test to make sure
that hasattr/setattr works, the test code will be equivalent to the actual code,
which seems silly...

I did run this locally, so it DOES work... I'm just not sure how to unittest it
:/

[M-A Ruel, 2013-03-07 15:50:32]

https://chromiumcodereview.appspot.com/12481002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://chromiumcodereview.appspot.com/12481002/diff/1/presubmit_support.py#n...
presubmit_support.py:1248: for method_name in options.skip_canned:
I'd like you to restore them after.

missing = [m for m in options.skip_canned if not
hasattr(presubmit_canned_checks, m)]
if missing:
  parser.error(
      'Attempted to skip nonexistent canned presubmit check: %s' % ',
'.join(missing))

previous = dict((m, getattr(presubmit_canned_checks, m)) for m in
options.skip_canned)

try:
..
except ...:
...
finally:
  for m, l in previous.iteritems():
    setattr(...

[iannucci, 2013-03-07 19:39:14]

On 2013/03/07 15:50:32, Marc-Antoine Ruel wrote:
> https://chromiumcodereview.appspot.com/12481002/diff/1/presubmit_support.py
> File presubmit_support.py (right):
> 
>
https://chromiumcodereview.appspot.com/12481002/diff/1/presubmit_support.py#n...
> presubmit_support.py:1248: for method_name in options.skip_canned:
> I'd like you to restore them after.
> 
> missing = [m for m in options.skip_canned if not
> hasattr(presubmit_canned_checks, m)]
> if missing:
>   parser.error(
>       'Attempted to skip nonexistent canned presubmit check: %s' % ',
> '.join(missing))
> 
> previous = dict((m, getattr(presubmit_canned_checks, m)) for m in
> options.skip_canned)
> 
> try:
> ..
> except ...:
> ...
> finally:
>   for m, l in previous.iteritems():
>     setattr(...

Ah, right, since things actually call Main directly. I'll fix this.

[iannucci, 2013-03-07 22:47:29]

OK, PTAL, I think you'll like this version... It even has tests now!

[M-A Ruel, 2013-03-08 02:09:02]

Impressed.

lgtm

https://chromiumcodereview.appspot.com/12481002/diff/7001/presubmit_support.py
File presubmit_support.py (right):

https://chromiumcodereview.appspot.com/12481002/diff/7001/presubmit_support.p...
presubmit_support.py:1204: 
2 lines

https://chromiumcodereview.appspot.com/12481002/diff/7001/presubmit_support.p...
presubmit_support.py:1210: if hasattr(presubmit_canned_checks, method_name):
if not hasattr():
  raise
then align -2 lines 1211-1212

[iannucci, 2013-03-08 08:13:23]

Committed patchset #2 manually as r186922 (presubmit successful).

[M-A Ruel, 2013-03-08 13:30:15]

On 2013/03/08 08:13:23, iannucci wrote:
> Committed patchset #2 manually as r186922 (presubmit successful).

You can use the CQ BTW

[iannucci1, 2013-03-08 19:19:01]

On 2013/03/08 13:30:15, Marc-Antoine Ruel wrote:
> On 2013/03/08 08:13:23, iannucci wrote:
> > Committed patchset #2 manually as r186922 (presubmit successful).
> 
> You can use the CQ BTW

Oops, I forgot depot_tools was in cq