Add functions for DER parsing a BIT STRING.

net/der/parser.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "net/der/parse_values.h"
 #include "net/der/parser.h"
 
 namespace net {
@@ skipping 168 matching lines @@
   return ReadConstructed(kSequence, out);
 }
 
 bool Parser::ReadUint64(uint64_t* out) {
   Input encoded_int;
   if (!ReadTag(kInteger, &encoded_int))
     return false;
   return ParseUint64(encoded_int, out);
 }
 
+bool Parser::ReadBitString(Input* bytes, uint8_t* unused_bits) {
+  Input value;
+  if (!ReadTag(kBitString, &value))
+    return false;
+  return ParseBitString(value, bytes, unused_bits);
+}
+
+bool Parser::ReadBitStringNoUnusedBits(Input* bytes) {
+  uint8_t unused_bits;
+  if (!ReadBitString(bytes, &unused_bits))
+    return false;
+  return unused_bits == 0;

[nharper, 2015/07/21 23:23:47]

This approach results in modifying *bytes even if the method returns false. I
believe that the rest of the Parser methods only modify output parameters if
they return true. (ParseBitString does this correctly by declaring Input bytes
(parse_values.cc:180) and only assigning it to the output parameter if the
function is going to return true (parse_values.cc:195).)

[eroman, 2015/07/22 17:05:23]

Done.

+}
+
 }  // namespace der
 
 }  // namespace net