MIPS Android: use asm/sgidefs.h instead of sgidefs.h

MIPS Android: use asm/sgidefs.h instead of sgidefs.h

Including LSS from Chromium's base_unittests breaks compilation on MIPS
Android. Breakpad works around this by suppling an sgidefs.h that just
includes asm/sgidefs.h. This CL makes LSS include asm/sgidefs.h
directly when building for MIPS Android, preventing other projects for
having to apply the same workaround.

BUG=512384
Patch contributed by Ian Cullinan (cullinan@amazon.com).

R=mseaborn@chromium.org

Committed: https://code.google.com/p/linux-syscall-support/source/detail?r=36

[Ian Cullinan, 2015-07-21 22:21:00]

cullinan@amazon.com changed reviewers:
+ mseaborn@chromium.org

[Ian Cullinan, 2015-07-21 22:21:26]

PTAL

[Nico, 2015-07-21 22:23:59]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-21 22:23:59]

seee https://www.chromium.org/developers/adding-3rd-party-libraries – can this
be upstreamed? in any reason, README.chromium should document the local change
(but ideally that would just be "cherry-pick upstream rev XXX", or a roll
forward to a newer upstream rev)

[Ian Cullinan, 2015-07-21 22:30:08]

On 2015/07/21 22:23:59, Nico (hiding) wrote:
> seee https://www.chromium.org/developers/adding-3rd-party-libraries – can
this
> be upstreamed? in any reason, README.chromium should document the local change
> (but ideally that would just be "cherry-pick upstream rev XXX", or a roll
> forward to a newer upstream rev)

This is intended as an upstream change, following the instructions from
https://code.google.com/p/linux-syscall-support/wiki/HowToContribute

I will follow up with a DEPS roll and then a re-land of
htts://crrev.com/1241333002

[Mark Seaborn, 2015-07-22 00:53:55]

LGTM I suppose.  Could this be fixed in Bionic by adding sgidefs.h there?  (I
haven't got much idea of how incomplete MIPS Bionic is.)

https://codereview.chromium.org/1248033002/diff/1/linux_syscall_support.h
File linux_syscall_support.h (right):

https://codereview.chromium.org/1248033002/diff/1/linux_syscall_support.h#new...
linux_syscall_support.h:122: /* Android doesn't have sgidefs.h, but does have
<asm/sgidefs.h,
Missing ">" here

[Ian Cullinan, 2015-07-22 01:19:04]

On 2015/07/22 00:53:55, Mark Seaborn wrote:
> LGTM I suppose.  Could this be fixed in Bionic by adding sgidefs.h there?  (I
> haven't got much idea of how incomplete MIPS Bionic is.)

Looks like it's there for API 21, but Chromium is building against API 16 (at
least for 32-bit arches, see
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&...
)

> https://codereview.chromium.org/1248033002/diff/1/linux_syscall_support.h
> File linux_syscall_support.h (right):
> 
>
https://codereview.chromium.org/1248033002/diff/1/linux_syscall_support.h#new...
> linux_syscall_support.h:122: /* Android doesn't have sgidefs.h, but does have
> <asm/sgidefs.h,
> Missing ">" here

Fixed

Can you please land this for me?

[Ian Cullinan, 2015-07-30 00:19:26]

Hi Mark,

Is there anything else I need to do to get this landed?

Thanks,
Ian

[Ian Cullinan, 2015-08-11 20:54:36]

The CQ bit was checked by cullinan@amazon.com

[Ian Cullinan, 2015-08-11 20:54:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
mseaborn@chromium.org
Link to the patchset: https://codereview.chromium.org/1248033002/#ps2 (title:
"fix typo")

[commit-bot: I haz the power, 2015-08-11 20:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-11 20:55:03]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Mark Seaborn, 2015-08-11 21:15:29]

Committed patchset #2 (id:2) manually as 36 (presubmit successful).

[Mark Seaborn, 2015-08-11 21:36:34]

On 2015/07/22 01:19:04, Ian Cullinan wrote:
> Can you please land this for me?

Done now.  Would you like to roll this into Chromium's DEPS?

[Ian Cullinan, 2015-08-11 21:40:34]

On 2015/08/11 21:36:34, Mark Seaborn wrote:
> On 2015/07/22 01:19:04, Ian Cullinan wrote:
> > Can you please land this for me?
> 
> Done now.  Would you like to roll this into Chromium's DEPS?

Thanks. I'll post a DEPS roll CL shortly.