Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 12480004: Update .bat wrappers used for native messaging tests to pass arguments (Closed)

Created:
7 years, 9 months ago by Sergey Ulanov
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews
Visibility:
Public.

Description

Update .bat wrappers used for native messaging tests to pass arguments On Windows echo.bat and empty_app.bat used by native messaging tests invoke test python scripts. Update these files to all pass the arguments. This is a portion of https://codereview.chromium.org/12406002/ that fails to apply on trybots. BUG=142915 NOTRY=true TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/data/native_messaging/native_hosts/echo.bat View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/native_messaging/native_hosts/empty_app.bat View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sergey Ulanov
7 years, 9 months ago (2013-03-05 22:05:57 UTC) #1
Sergey Ulanov
Committed patchset #1 manually as r186268 (presubmit successful).
7 years, 9 months ago (2013-03-05 22:09:54 UTC) #2
Matt Perry
7 years, 9 months ago (2013-03-05 22:11:54 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698