Fixing some warnings on Linux

src/pdf/SkPDFCatalog.cpp

 
 /*
  * Copyright 2010 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkPDFCatalog.h"
@@ skipping 111 matching lines @@
     stream->writeText(" ");
     stream->writeDecAsText(last - first + 1);
     stream->writeText("\n");
 
     if (first == -1) {
         stream->writeText("0000000000 65535 f \n");
         first++;
     }
     for (int i = first; i <= last; i++) {
         SkASSERT(fCatalog[i].fFileOffset > 0);
-        SkASSERT(fCatalog[i].fFileOffset <= 9999999999LL);
+        SkASSERT(fCatalog[i].fFileOffset < 2147483647);

[sugoi, 2013/03/06 16:14:59]

On 32 bits platforms, off_t is a 32 bits signed integer, so we have to test
against a slightly smaller value to make sure it's always valid, otherwise, the
test will always be true on these platforms. I'm assuming 9999999999 was an
arbitrarily large number anyway.

         stream->writeBigDecAsText(fCatalog[i].fFileOffset, 10);
         stream->writeText(" 00000 n \n");
     }
 
     return fCatalog.count() + 1;
 }
 
 void SkPDFCatalog::setSubstitute(SkPDFObject* original,
                                  SkPDFObject* substitute) {
 #if defined(SK_DEBUG)
@@ skipping 56 matching lines @@
     SkTDArray<SkPDFObject*>* targetList = getSubstituteList(firstPage);
     for (int i = 0; i < targetList->count(); ++i) {
         (*targetList)[i]->emit(stream, this, true);
     }
 }
 
 SkTDArray<SkPDFObject*>* SkPDFCatalog::getSubstituteList(bool firstPage) {
     return firstPage ? &fSubstituteResourcesFirstPage :
                        &fSubstituteResourcesRemaining;
 }