chrome/installer/setup/BUILD.gn - Issue 1247993002: Return Windows error code when create-process fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/BUILD.gn

Issue 1247993002: Return Windows error code when create-process fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: untabify and rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/setup/BUILD.gn

diff --git a/chrome/installer/setup/BUILD.gn b/chrome/installer/setup/BUILD.gn

index 5809a9d86c3557d12165b2baf347fa2c131b70b0..08f5e4cba5ac1a6d954676e2baee149ee98bcaeb 100644

--- a/chrome/installer/setup/BUILD.gn

+++ b/chrome/installer/setup/BUILD.gn

@@ -19,9 +19,13 @@ if (is_win) {

"../mini_installer/decompress.cc",

"../mini_installer/decompress.h",

"../mini_installer/decompress_test.cc",

+ "../mini_installer/mini_installer_constants.cc",

+ "../mini_installer/mini_installer_constants.h",

"../mini_installer/mini_string.cc",

"../mini_installer/mini_string.h",

"../mini_installer/mini_string_test.cc",

+ "../mini_installer/regkey.cc",

+ "../mini_installer/regkey.h",

"app_launcher_installer.cc", # Move to lib

"app_launcher_installer.h", # Move to lib

"archive_patch_helper.cc", # Move to lib

« no previous file with comments | « chrome/installer/mini_installer/regkey.cc ('k') | no next file » | no next file with comments »