chrome/installer/mini_installer/mini_installer_constants.cc - Issue 1247993002: Return Windows error code when create-process fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer/mini_installer_constants.cc

Issue 1247993002: Return Windows error code when create-process fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed configuration tests and added new ones Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/mini_installer/mini_installer.cc ('K') | « chrome/installer/mini_installer/mini_installer_constants.h ('k') | chrome/installer/mini_installer/regkey.h » ('j') | chrome/installer/mini_installer/regkey.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/mini_installer/mini_installer_constants.cc

diff --git a/chrome/installer/mini_installer/mini_installer_constants.cc b/chrome/installer/mini_installer/mini_installer_constants.cc

index 65d1fd91a4e2f39460cdb125db67a7fd413e632a..f17d448d416cae525a13c623594ac3801b9b92d1 100644

--- a/chrome/installer/mini_installer/mini_installer_constants.cc

+++ b/chrome/installer/mini_installer/mini_installer_constants.cc

@@ -46,6 +46,10 @@ const wchar_t kApRegistryValue[] = L"ap";

// The name of the value in kCleanupRegistryKey that tells the installer not to

// delete extracted files.

const wchar_t kCleanupRegistryValue[] = L"ChromeInstallerCleanup";

+// These values provide installer result codes to Omaha.

+const wchar_t kInstallerErrorRegistryValue[] = L"InstallerError";

+const wchar_t kInstallerExtraCode1RegistryValue[] = L"InstallerExtraCode1";

+const wchar_t kInstallerResultRegistryValue[] = L"InstallerResult";

// The name of an app's Client State registry value that holds the path to its

// uninstaller.

const wchar_t kUninstallRegistryValue[] = L"UninstallString";