Fix race condition when accessing time_progressing_.

media/renderers/video_renderer_impl.h

Index: media/renderers/video_renderer_impl.h
diff --git a/media/renderers/video_renderer_impl.h b/media/renderers/video_renderer_impl.h
index 7af8bb724f686a3191bfb0fa6a6048e62ad1a8da..ff2b4adc0bdd36841c2f9a80bcf3b569d8d435a6 100644
--- a/media/renderers/video_renderer_impl.h
+++ b/media/renderers/video_renderer_impl.h
@@ -147,8 +147,15 @@ class MEDIA_EXPORT VideoRendererImpl
 
   // Fires |ended_cb_| if there are no remaining usable frames and
   // |received_end_of_stream_| is true.  Sets |rendered_end_of_stream_| if it
-  // does so.  Returns algorithm_->EffectiveFramesQueued().
-  size_t MaybeFireEndedCallback();
+  // does so.
+  //
+  // When called from the media thread, |time_progressing| should reflect the
+  // value of |time_progressing_|.  When called from Render() on the sink
+  // callback thread, the inverse of |render_first_frame_and_stop_| should be
+  // used as a proxy for |time_progressing_|.
+  //
+  // Returns algorithm_->EffectiveFramesQueued().
+  size_t MaybeFireEndedCallback(bool time_progressing);
 
   // Helper method for converting a single media timestamp to wall clock time.
   base::TimeTicks ConvertMediaTimestamp(base::TimeDelta media_timestamp);
@@ -271,7 +278,8 @@ class MEDIA_EXPORT VideoRendererImpl
   // counted.  Must be accessed under |lock_| once |sink_| is started.
   bool was_background_rendering_;
 
-  // Indicates whether or not media time is currently progressing or not.
+  // Indicates whether or not media time is currently progressing or not.  Must
+  // only be accessed on the media thread.

[xhwang, 2015/07/21 21:01:38]

This file doesn't know about the media thread. Replace it with something related
to the task runner?

[DaleCurtis, 2015/07/22 00:44:44]

Done.

   bool time_progressing_;
 
   // Indicates that Render() should only render the first frame and then request