Issue 124793003: Data reduction proxy reconfigured on pref view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124793003: Data reduction proxy reconfigured on pref view (Closed)

Created:
6 years, 11 months ago by bengr

Modified:
6 years, 11 months ago

Reviewers:
marq_use_my_chromium_address, marq (ping after 24h)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Data reduction proxy reconfigured on pref view On Android, viewing the data reduction settings screen would trigger configuring the proxy, even if the user did not change the data reduction proxy enabled pref. This CL limits reconfigurations to actual pref changes, which reduces the work Chrome needs to do. BUG=181049 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245138

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/net/spdyproxy/data_reduction_proxy_settings.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/124793003/1

6 years, 11 months ago (2014-01-15 21:27:28 UTC) #3

Message was sent while issue was closed.

Change committed as 245138

Expand Messages | Collapse Messages