Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1247843002: Fix tonic include guards (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -81 lines) Patch
M tonic/dart_api_scope.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_builtin.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_class_library.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_class_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_converter_wtf.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_dependency_catcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_error.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_exception_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_gc_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_gc_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_gc_visitor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_invoke.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_isolate_scope.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_library_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_library_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_persistent_value.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_snapshot_loader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_string.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_string_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_timer_heap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_value.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_wrappable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/dart_wrapper_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/float32_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tonic/mojo_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 5 months ago (2015-07-21 18:18:50 UTC) #2
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-21 18:25:03 UTC) #4
Cutch
5 years, 5 months ago (2015-07-21 18:25:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c27a98c20387d797b017b35c08b08bfcbeb91f17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698