Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1247833003: Handle UINT64_MAX edge case in switch lowering. (Closed)

Created:
5 years, 5 months ago by ascull
Modified:
5 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make test more readable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M src/IceSwitchLowering.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/adv-switch-opt.ll View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ascull
The 64-bit lowering is still done the old way (even though it is analysed and ...
5 years, 5 months ago (2015-07-23 19:32:31 UTC) #1
jvoung (off chromium)
LGTM thanks https://codereview.chromium.org/1247833003/diff/1/tests_lit/llvm2ice_tests/adv-switch-opt.ll File tests_lit/llvm2ice_tests/adv-switch-opt.ll (right): https://codereview.chromium.org/1247833003/diff/1/tests_lit/llvm2ice_tests/adv-switch-opt.ll#newcode200 tests_lit/llvm2ice_tests/adv-switch-opt.ll:200: i64 18446744073709551615, label %sw.bb3 I think technically ...
5 years, 5 months ago (2015-07-23 21:26:34 UTC) #2
ascull
5 years, 5 months ago (2015-07-23 21:31:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
016c56d966eb913007f781b5b90c676322180679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698