Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1247803006: Fixes possible use after free in WebLayerTreeViewImpl (Closed)

Created:
5 years, 5 months ago by sky
Modified:
5 years, 5 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes possible use after free in WebLayerTreeViewImpl WebLayerTreeViewImpl needs to destroy LayerTreeHost early on as otherwise it's possible for the compositor thread to be accessing WebLayerTreeViewImpl while WebLayerTreeViewImpl is part way through the destructor and in a bad state. BUG=none TEST=none R=fsamuel@chromium.org Committed: https://crrev.com/918daff46650a7b3605fdb6c3c72b5ec3bfa687e Cr-Commit-Position: refs/heads/master@{#339785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sky
5 years, 5 months ago (2015-07-21 22:34:50 UTC) #1
Fady Samuel
lgtm
5 years, 5 months ago (2015-07-21 23:28:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247803006/1
5 years, 5 months ago (2015-07-21 23:31:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 23:53:07 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 23:54:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918daff46650a7b3605fdb6c3c72b5ec3bfa687e
Cr-Commit-Position: refs/heads/master@{#339785}

Powered by Google App Engine
This is Rietveld 408576698