Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: pkg/intl/test/message_extraction/message_extraction_test.dart

Issue 12478010: Parameterize the import directories, fix test to behave correctly on an error (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/intl/lib/generate_localized.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/intl/test/message_extraction/message_extraction_test.dart
diff --git a/pkg/intl/test/message_extraction/message_extraction_test.dart b/pkg/intl/test/message_extraction/message_extraction_test.dart
index 0b00fdb99f8a8fb3d6137a3686ee3f7ae815eb6b..9b4e3520e19bc95f00ec2bed37bb73b9abc41f7c 100644
--- a/pkg/intl/test/message_extraction/message_extraction_test.dart
+++ b/pkg/intl/test/message_extraction/message_extraction_test.dart
@@ -55,16 +55,20 @@ main() {
test("Test round trip message extraction, translation, code generation, "
"and printing", () {
deleteGeneratedFiles();
- extractMessages(null).then((result) {
Emily Fortuna 2013/03/19 20:31:37 if you just add a return statement at this line: r
Alan Knight 2013/03/19 20:53:46 Done.
- return generateTranslationFiles(result);
- }).then((result) {
- return generateCodeFromTranslation(result);
- }).then((result) {
- return runGeneratedCode(result);
- }).then(verifyResult);
+ return runTheTest();
});
}
+Future runTheTest() {
+ return extractMessages(null).then((result) {
+ return generateTranslationFiles(result);
+ }).then((result) {
+ return generateCodeFromTranslation(result);
+ }).then((result) {
+ return runGeneratedCode(result);
+ }).then(verifyResult);
+}
+
void deleteGeneratedFiles() {
var files = [dir('intl_messages.json'), dir('translation_fr.json'),
dir('messages_fr.dart'), dir('message_de_DE.dart'),
@@ -124,7 +128,7 @@ Future<ProcessResult> generateCodeFromTranslation(ProcessResult previousResult)
Future<ProcessResult> runGeneratedCode(ProcessResult previousResult) =>
run(previousResult, ['sample_with_messages.dart']);
-void verifyResult(results) {
+verifyResult(results) {
var lineIterator;
verify(String s) {
lineIterator.moveNext();
« no previous file with comments | « pkg/intl/lib/generate_localized.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698