Make array allocation stub shared between isolates.

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 446 matching lines @@
   }
 
   void walk() {
     sample_->set_exit_frame_sample(false);
     if (!ValidFramePointer()) {
       sample_->set_ignore_sample(true);
       return;
     }
     ASSERT(ValidFramePointer());
     uword return_pc = InitialReturnAddress();
-    if (StubCode::InInvocationStubForIsolate(isolate_, return_pc)) {
+    if (StubCode::InInvocationStub(return_pc)) {
       // Edge case- we have called out from the Invocation Stub but have not
       // created the stack frame of the callee. Attempt to locate the exit
       // frame before walking the stack.
       if (!NextExit() || !ValidFramePointer()) {
         // Nothing to sample.
         sample_->set_ignore_sample(true);
         return;
       }
     }
     for (int i = 0; i < NumberOfFramesToCollect(); i++) {
       sample_->SetAt(i, reinterpret_cast<uword>(pc_));
       if (!Next()) {
         return;
       }
     }
     sample_->set_truncated_trace(true);
   }
 
  private:
   bool Next() {
     if (!ValidFramePointer()) {
       return false;
     }
-    if (StubCode::InInvocationStubForIsolate(isolate_,
-                                             reinterpret_cast<uword>(pc_))) {
+    if (StubCode::InInvocationStub(reinterpret_cast<uword>(pc_))) {
       // In invocation stub.
       return NextExit();
     }
     // In regular Dart frame.
     uword* new_pc = CallerPC();
     // Check if we've moved into the invocation stub.
-    if (StubCode::InInvocationStubForIsolate(isolate_,
-                                             reinterpret_cast<uword>(new_pc))) {
+    if (StubCode::InInvocationStub(reinterpret_cast<uword>(new_pc))) {
       // New PC is inside invocation stub, skip.
       return NextExit();
     }
     uword* new_fp = CallerFP();
     if (new_fp <= fp_) {
       // FP didn't move to a higher address.
       return false;
     }
     // Success, update fp and pc.
     fp_ = new_fp;
@@ skipping 309 matching lines @@
 }
 
 
 void Profiler::RecordAllocation(Isolate* isolate, intptr_t cid) {
   if ((isolate == NULL) || (Dart::vm_isolate() == NULL)) {
     // No isolate.
     return;
   }
   ASSERT(isolate != Dart::vm_isolate());
 
-  const bool exited_dart_code = (isolate->stub_code() != NULL) &&
-                                (isolate->top_exit_frame_info() != 0) &&
+  const bool exited_dart_code = (isolate->top_exit_frame_info() != 0) &&
                                 (isolate->vm_tag() != VMTag::kDartTagId);
 
   if (!exited_dart_code) {
     // No Dart frames on stack.
     // TODO(johnmccutchan): Support collecting native stack.
     return;
   }
 
   IsolateProfilerData* profiler_data = isolate->profiler_data();
   if (profiler_data == NULL) {
@@ skipping 34 matching lines @@
     const InterruptedThreadState& state,
     void* data) {
   Isolate* isolate = reinterpret_cast<Isolate*>(data);
   if ((isolate == NULL) || (Dart::vm_isolate() == NULL)) {
     // No isolate.
     return;
   }
 
   ASSERT(isolate != Dart::vm_isolate());
 
-  const bool exited_dart_code = (isolate->stub_code() != NULL) &&
-                                (isolate->top_exit_frame_info() != 0) &&
+  const bool exited_dart_code = (isolate->top_exit_frame_info() != 0) &&
                                 (isolate->vm_tag() != VMTag::kDartTagId);
-  const bool in_dart_code = (isolate->stub_code() != NULL) &&
-                            (isolate->top_exit_frame_info() == 0) &&
+  const bool in_dart_code = (isolate->top_exit_frame_info() == 0) &&
                             (isolate->vm_tag() == VMTag::kDartTagId);
 
   uintptr_t sp = 0;
   uintptr_t fp = state.fp;
   uintptr_t pc = state.pc;
   uintptr_t lr = state.lr;
 #if defined(USING_SIMULATOR)
   Simulator* simulator = NULL;
 #endif
 
@@ skipping 331 matching lines @@
                                                uword pc) {
   return vm_isolate->heap()->CodeContains(pc)
          || isolate->heap()->CodeContains(pc);
 }
 
 
 ProcessedSampleBuffer::ProcessedSampleBuffer() {
 }
 
 }  // namespace dart