Issue 1247763002: [test] Pin v8-perf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247763002: [test] Pin v8-perf.

Created:
5 years, 5 months ago by Michael Achenbach

Modified:
5 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit), Sergiy Byelozyorov

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[test] Pin v8-perf. BUG=chromium:512359 NOTRY=true

Patch Set 1 #

Total comments: 3

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	DEPS	View		2 chunks	+6 lines, -1 line	3 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

PTAL https://codereview.chromium.org/1247763002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1247763002/diff/1/DEPS#newcode25 DEPS:25: deps_os = { I'd love to rename this ...

5 years, 5 months ago (2015-07-21 09:56:59 UTC) #2

Sergiy Byelozyorov

5 years, 5 months ago (2015-07-21 11:36:37 UTC) #3

https://codereview.chromium.org/1247763002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1247763002/diff/1/DEPS#newcode25
DEPS:25: deps_os = {
On 2015/07/21 09:56:59, Michael Achenbach wrote:
> I'd love to rename this to "conditional_deps", but I guess that'll snowball a
> lot.

I'd file a bug with Build-Tools label. I doubt it'll snowball too much, but we
must be sure that this is indeed "conditional" deps.

https://codereview.chromium.org/1247763002/diff/1/DEPS#newcode34
DEPS:34: "perf-internal": {
How does "os" value get computed? Is it in a config somewhere?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages