Issue 1247743004: Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247743004: Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test (Closed)

Created:
5 years, 5 months ago by Mike Wittman

Modified:
5 years, 5 months ago

Reviewers:
battre, matthewtff.asm

CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, Mike Wittman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test (patchset #1 id:1 of https://codereview.chromium.org/1222193006/) Reason for revert: Breaks linux clang tot bot (https://crbug.com/512506) and causes flakiness on Vista Tests bot (https://crbug.com/512431). BUG=512506, 512431 Original issue's description: > Remove race in DeclarativeContentApiTest.RulesPersistence test > > BUG= > > Committed: https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b > Cr-Commit-Position: refs/heads/master@{#339432} TBR=battre@chromium.org,matthewtff@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/87aa531635fc08a2dafa4b34048154e43f7d9aab Cr-Commit-Position: refs/heads/master@{#339713}

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc	View		2 chunks	+7 lines, -10 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/declarative_content/persistence/background.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Mike Wittman

Created Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test

5 years, 5 months ago (2015-07-21 19:20:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247743004/1

5 years, 5 months ago (2015-07-21 19:21:25 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-21 19:49:04 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/87aa531635fc08a2dafa4b34048154e43f7d9aab
Cr-Commit-Position: refs/heads/master@{#339713}