Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: tests/lib/mirrors/hot_get_field_test.dart

Issue 1247733005: Fix getField optimization when the selector is an operator. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/hot_get_field_test.dart
diff --git a/tests/lib/mirrors/hot_get_field_test.dart b/tests/lib/mirrors/hot_get_field_test.dart
index ca798d377addca8cc8cfd693843a53d7825dad2e..6673818d0f5a7c3a04967e538e2d1d0d24a9013e 100644
--- a/tests/lib/mirrors/hot_get_field_test.dart
+++ b/tests/lib/mirrors/hot_get_field_test.dart
@@ -10,6 +10,7 @@ import 'package:expect/expect.dart';
class C {
var field;
var _field;
+ operator +(other) => field + other;
}
const int optimizationThreshold = 20;
@@ -44,8 +45,22 @@ testPrivateWrongLibrary() {
}
}
+testOperator() {
+ var plus = const Symbol("+");
+ var c = new C();
+ var im = reflect(c);
+
+ for (int i = 0; i < (2 * optimizationThreshold); i++) {
+ c.field = i;
+ var closurizedPlus = im.getField(plus).reflectee;
+ Expect.isTrue(closurizedPlus is Function);
+ Expect.equals(2 * i, closurizedPlus(i));
+ }
+}
+
main() {
testPublic();
testPrivate();
testPrivateWrongLibrary();
+ testOperator();
}
« no previous file with comments | « runtime/lib/mirrors_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698