Port some gtest.gyp settings to the BUILD.gn file

tools/gn/secondary/testing/gtest/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("gtest_config") {
-  defines = [ "UNIT_TEST" ]
+  defines = [
+    "UNIT_TEST",
+    "GTEST_HAS_POSIX_RE=0",
+    "GTEST_HAS_RTTI=0",
+  ]
+
   include_dirs = [ "include" ]  # Gtest headers need to be able to find themselves.

[brettw, 2014/01/06 20:41:29]

Can you fix this long line while you're here (probably put it on the previous
line is the most clear).

[tfarina, 2014/01/06 22:48:15]

Done.

+
   if (is_win) {
     cflags = [ "/wd4800" ]  # Unused variable warning.
   }
 }
 
 static_library("gtest") {
   external = true
   gyp_file = "gtest.gyp"
   sources = [
     "include/gtest/gtest-death-test.h",
@@ skipping 22 matching lines @@
     "src/gtest-port.cc",
     "src/gtest-printers.cc",
     "src/gtest-test-part.cc",
     "src/gtest-typed-test.cc",
     "src/gtest.cc",
     "../multiprocess_func_list.cc",
     "../multiprocess_func_list.h",
     "../platform_test.h",
   ]
 
+  defines = [
+    # In order to allow regex matches in gtest to be shared between Windows
+    # and other systems, we tell gtest to always use it's internal engine.
+    "GTEST_HAS_POSIX_RE=0",

[brettw, 2014/01/06 20:41:29]

You don't need this, same reason as below.

[tfarina, 2014/01/06 22:48:15]

Done.

+  ]
+
+  if (is_posix) {
+    defines += [
+      # gtest isn't able to figure out when RTTI is disabled for gcc
+      # versions older than 4.3.2, and assumes it's enabled.  Our Mac
+      # and Linux builds disable RTTI, and cannot guarantee that the
+      # compiler will be 4.3.2. or newer.  The Mac, for example, uses
+      # 4.2.1 as that is the latest available on that platform.  gtest
+      # must be instructed that RTTI is disabled here, and for any
+      # direct dependents that might include gtest headers.
+      "GTEST_HAS_RTTI=0",

[brettw, 2014/01/06 20:41:29]

You don't need this since it's on the config, and direct/all_dependent_configs
also apply to the current target. So setting it in the gtest_config above should
cover this target.

[tfarina, 2014/01/06 22:48:15]

Done.

+    ]
+    direct_dependent_configs = [ ":gtest_config" ]

[brettw, 2014/01/06 20:41:29]

You don't need this since you add it below.

[tfarina, 2014/01/06 22:48:15]

Done.

+  }
+
   if (is_mac) {
     sources += [
       "gtest_mac.h",
       "gtest_mac.mm",
       "platform_test_mac.mm",
     ]
   }
 
   include_dirs = [ "." ]
-  direct_dependent_configs = [ ":gtest_config" ]
+  all_dependent_configs = [ ":gtest_config" ]
+  direct_dependent_configs += [ ":gtest_config" ]

[brettw, 2014/01/06 20:41:29]

You don't need this since 'all' handles everything. 'direct' is just one level,
so is a subset of 'all'.

[tfarina, 2014/01/06 22:48:15]

Done.

 
   configs -= "//build/config/compiler:chromium_code"
   configs += "//build/config/compiler:no_chromium_code"
 }