Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1247723003: Remove high promotion mode (Closed)

Created:
5 years, 5 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove high promotion mode High promotion mode limits new space size in the case where many objects (high rate) are promoted. The result is frequent scavenger runs with low pause times. The approach conflicts with pretenuring which requires a larger new space size to collect enough feedback to be usable. Ultimately the goal is to have pretenuring catch allocation sites that have high promotion rates. Revert "Bring back high promotion mode to shrink young generation size when scavenging latency is high." This reverts commit 37be1d5e9e0a34abe6ba1612b9825e59f28a52d8. Revert "GC. Delay/avoid entering high promotion mode" This reverts commit a5221d0779d0839055c764b88f412a0793d959b3. BUG=chromium:499507, chromium:506910 LOG=n Committed: https://crrev.com/40bb3a58a0a2c4fb85bad668e2489977df449277 Cr-Commit-Position: refs/heads/master@{#29983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -140 lines) Patch
M src/heap/heap.h View 3 chunks +2 lines, -63 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +2 lines, -77 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
5 years, 5 months ago (2015-07-21 07:58:07 UTC) #2
Hannes Payer (out of office)
This does not work well with pretenuring. We are going to remove it, again. LGTM
5 years, 4 months ago (2015-08-03 16:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247723003/1
5 years, 4 months ago (2015-08-03 16:59:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 17:29:36 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 17:29:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40bb3a58a0a2c4fb85bad668e2489977df449277
Cr-Commit-Position: refs/heads/master@{#29983}

Powered by Google App Engine
This is Rietveld 408576698