Enable print forwarding.

Enable print forwarding.

R=ager@google.com,ahe@google.com,podivilov@chromium.org

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1131

[ahe, 2013-03-12 19:43:24]

Thank you, Anton!

This looks right, but I don't understand the code. I'm sure Mads or Pavel can
review this.

[Mads Ager (google), 2013-03-13 07:06:17]

LGTM, but could you explain why and when we want to do this? Please put the
explanation in the code as a comment as well so we remember why it is there.

https://codereview.chromium.org/12477005/diff/1/Source/WebCore/bindings/dart/...
File Source/WebCore/bindings/dart/DartController.cpp (right):

https://codereview.chromium.org/12477005/diff/1/Source/WebCore/bindings/dart/...
Source/WebCore/bindings/dart/DartController.cpp:138: copyValue(html,
getenv("DART_FORWARDING_PRINT") ? "_forwardingPrintClosure" : "_printClosure",
"dart:core", 0, "_printClosure");
Could you add a comment about this Anton. I have no idea why we would want to
call a JS function called dartPrint instead of doing what we currently do on
print?

[Anton Muhin, 2013-03-13 08:56:19]

Mads, sorry, I should have done it before.

I've added a comment in the sources.

https://codereview.chromium.org/12477005/diff/1/Source/WebCore/bindings/dart/...
File Source/WebCore/bindings/dart/DartController.cpp (right):

https://codereview.chromium.org/12477005/diff/1/Source/WebCore/bindings/dart/...
Source/WebCore/bindings/dart/DartController.cpp:138: copyValue(html,
getenv("DART_FORWARDING_PRINT") ? "_forwardingPrintClosure" : "_printClosure",
"dart:core", 0, "_printClosure");
I've added a comment right before forwardingPrint, may you have a look, please?

On 2013/03/13 07:06:17, Mads Ager wrote:
> Could you add a comment about this Anton. I have no idea why we would want to
> call a JS function called dartPrint instead of doing what we currently do on
> print?

[Mads Ager (google), 2013-03-13 09:15:12]

LGTM, thanks Anton!

[Anton Muhin, 2013-03-13 09:17:56]

Committed patchset #2 manually as r1131 (presubmit successful).