chrome/browser/webdata/web_data_service_observer.h - Issue 12476031: Refactor notifications of chrome/browser/webdata

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/webdata/web_data_service_observer.h

Issue 12476031: Refactor notifications of chrome/browser/webdata (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase again Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/webdata/web_data_service.h ('K') | « chrome/browser/webdata/web_data_service.cc ('k') | chrome/browser/webdata/web_data_service_unittest.cc » ('j') | components/autofill/browser/personal_data_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	dhollowa 2013/03/12 22:22:28 nit: No need for "(c)" nit: No need for "(c)" kaiwang 2013/03/13 04:57:20 Are you sure? Most of the code have this... Are you sure? Most of the code have this... dhollowa 2013/03/13 16:15:28 http://crbug.com/140977 Show quoted text On 2013/03/13 04:57:20, kaiwang wrote: > Are you sure? Most of the code have this... http://crbug.com/140977
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_OBSERVER_H_

	6 #define CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_OBSERVER_H_

	7

	8 #include "chrome/browser/webdata/autofill_change.h"

	9

	10 class WebDataServiceObserver {
	Jói 2013/03/12 23:27:34 Kai, can you add a TODO here that we'll need to sp Kai, can you add a TODO here that we'll need to split this into an Autofill-specific part and the rest, once we split the Autofill parts of WebDataService off into a separate concrete class? kaiwang 2013/03/13 04:57:20 Done. Show quoted text On 2013/03/12 23:27:34, Jói wrote: > Kai, can you add a TODO here that we'll need to split this into an > Autofill-specific part and the rest, once we split the Autofill parts of > WebDataService off into a separate concrete class? Done.
	11 public:

	12 // Called whenever autofill entries are changed.
	dhollowa 2013/03/12 22:22:28 nit: capitalize "Autofill" when talking about the nit: capitalize "Autofill" when talking about the feature (noun), lower case "autofill" when using it as a verb. kaiwang 2013/03/13 04:57:20 Done. Show quoted text On 2013/03/12 22:22:28, dhollowa wrote: > nit: capitalize "Autofill" when talking about the feature (noun), lower case > "autofill" when using it as a verb. Done.
	13 virtual void AutofillEntriesChanged(const AutofillChangeList& changes) {}

	14

	15 // Called when an AutofillProfile has been added/removed/updated in the

	16 // WebDatabase.

	17 virtual void AutofillProfileChanged(const AutofillProfileChange& change) {}

	18

	19 // Called when multiple Autofill entries have been modified by Sync.

	20 virtual void AutofillMultipleChanged() {}

	21

	22 // Called whenever the web database service has finished loading the web

	23 // database.

	24 virtual void WebDatabaseLoaded() {}

	25

	26 protected:

	27 virtual ~WebDataServiceObserver() {}

	28 };

	29

	30 #endif // CHROME_BROWSER_WEBDATA_WEB_DATA_SERVICE_OBSERVER_H_

OLD	NEW