Refactor notifications of chrome/browser/webdata

chrome/browser/webdata/autocomplete_syncable_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef CHROME_BROWSER_WEBDATA_AUTOCOMPLETE_SYNCABLE_SERVICE_H_
 #define CHROME_BROWSER_WEBDATA_AUTOCOMPLETE_SYNCABLE_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/non_thread_safe.h"
 #include "chrome/browser/webdata/autofill_change.h"
 #include "chrome/browser/webdata/autofill_entry.h"
 #include "chrome/browser/webdata/web_data_service.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
+#include "chrome/browser/webdata/web_data_service_observer.h"
 #include "sync/api/sync_change.h"
 #include "sync/api/sync_data.h"
 #include "sync/api/sync_error.h"
 #include "sync/api/syncable_service.h"
 
 class ProfileSyncServiceAutofillTest;
 
 namespace syncer {
 class SyncErrorFactory;
 }
 
 namespace sync_pb {
 class AutofillSpecifics;
 }
 
 // The sync implementation for autocomplete.
 // MergeDataAndStartSyncing() called first, it does cloud->local and
 // local->cloud syncs. Then for each cloud change we receive
 // ProcessSyncChanges() and for each local change Observe() is called.
 // TODO(georgey) : remove reliance on the notifications and make it to be called
 // from web_data_service directly.
-class AutocompleteSyncableService
-    : public syncer::SyncableService,
-      public content::NotificationObserver,
-      public base::NonThreadSafe {
+class AutocompleteSyncableService : public syncer::SyncableService,
+                                    public WebDataServiceObserver,
+                                    public base::NonThreadSafe {
  public:
   explicit AutocompleteSyncableService(WebDataService* web_data_service);
   virtual ~AutocompleteSyncableService();
 
   static syncer::ModelType model_type() { return syncer::AUTOFILL; }
 
   // syncer::SyncableService implementation.
   virtual syncer::SyncMergeResult MergeDataAndStartSyncing(
       syncer::ModelType type,
       const syncer::SyncDataList& initial_sync_data,
       scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
       scoped_ptr<syncer::SyncErrorFactory> error_handler) OVERRIDE;
   virtual void StopSyncing(syncer::ModelType type) OVERRIDE;
   virtual syncer::SyncDataList GetAllSyncData(
       syncer::ModelType type) const OVERRIDE;
   virtual syncer::SyncError ProcessSyncChanges(
       const tracked_objects::Location& from_here,
       const syncer::SyncChangeList& change_list) OVERRIDE;
 
-  // NotificationObserver implementation.
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE;
+  // WebDataServiceObserver implementation.
+  virtual void AutofillEntriesChanged(const AutofillChangeList& changes)

[dhollowa, 2013/03/12 22:22:28]

nit: wrap at the arg, not at the OVERRIDE.

[kaiwang, 2013/03/13 04:57:20]

Done.

+      OVERRIDE;
 
   // Called via sync to tell us if we should cull expired entries when merging
   // and/or processing sync changes.
   void UpdateCullSetting(bool cull_expired_entries);
   bool cull_expired_entries() const { return cull_expired_entries_; }
 
  protected:
   // Helper to query WebDatabase for the current autocomplete state.
   // Made virtual for ease of mocking in the unit-test.
   virtual bool LoadAutofillData(std::vector<AutofillEntry>* entries) const;
@@ skipping 52 matching lines @@
   // For unit-tests.
   AutocompleteSyncableService();
   void set_sync_processor(syncer::SyncChangeProcessor* sync_processor) {
     sync_processor_.reset(sync_processor);
   }
 
   // Lifetime of AutocompleteSyncableService object is shorter than
   // |web_data_service_| passed to it.
   WebDataService* web_data_service_;
 
-  content::NotificationRegistrar notification_registrar_;
-
   // We receive ownership of |sync_processor_| in MergeDataAndStartSyncing() and
   // destroy it in StopSyncing().
   scoped_ptr<syncer::SyncChangeProcessor> sync_processor_;
 
   // We receive ownership of |error_handler_| in MergeDataAndStartSyncing() and
   // destroy it in StopSyncing().
   scoped_ptr<syncer::SyncErrorFactory> error_handler_;
 
   // Whether we should cull expired autofill entries, can be updated by sync
   // via UpdateCullingSetting.
   bool cull_expired_entries_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteSyncableService);
 };
 
 #endif  // CHROME_BROWSER_WEBDATA_AUTOCOMPLETE_SYNCABLE_SERVICE_H_