pylib/gyp/generator/ninja.py - Issue 12476002: Create msvs_large_pdb workaround.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/generator/ninja.py

Issue 12476002: Create msvs_large_pdb workaround. (Closed) Base URL: https://git.chromium.org/git/external/gyp.git@master

Patch Set: Address review comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pylib/gyp/generator/ninja.py

diff --git a/pylib/gyp/generator/ninja.py b/pylib/gyp/generator/ninja.py

index be2b2a41aa373dbd421bc0ae267d2c144d391b1a..c6bceaf382a74d3bed32c6343cfb848faaf251c3 100644

--- a/pylib/gyp/generator/ninja.py

+++ b/pylib/gyp/generator/ninja.py

@@ -1784,6 +1784,9 @@ def GenerateOutput(target_list, target_dicts, data, params):

user_config = params.get('generator_flags', {}).get('config', None)

if gyp.common.GetFlavor(params) == 'win':

target_list, target_dicts = MSVSUtil.ShardTargets(target_list, target_dicts)

+ target_list, target_dicts = MSVSUtil.InsertLargePdbShims(

+ target_list, target_dicts, generator_default_variables)

if user_config:

GenerateOutputForConfig(target_list, target_dicts, data, params,

user_config)