Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: ui/base/BUILD.gn

Issue 1247593008: Fix running gn gen for //ui/* targets on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rlz
Patch Set: Address comments by danakj Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/compositor/BUILD.gn » ('j') | ui/events/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 824fe9ba075b210fc605225c552b1269122fdc85..643edda6433d5fa8ad84d1353e3f4b77797963da 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -696,7 +696,6 @@ test("ui_base_unittests") {
"test/data/resource.h",
"text/bytes_formatting_unittest.cc",
"touch/selection_bound_unittest.cc",
- "view_prop_unittest.cc",
"webui/web_ui_util_unittest.cc",
]
}
@@ -774,8 +773,8 @@ test("ui_base_unittests") {
]
}
- if (!is_win || !use_aura) {
- sources -= [ "view_prop_unittest.cc" ]
+ if (is_win && use_aura) {
+ sources += [ "view_prop_unittest.cc" ]
}
sadrul 2015/07/23 15:29:10 This doesn't look right. |is_win| implies |use_aur
sdefresne 2015/07/25 18:04:31 Sure, Done. In the previous patch just flipped the
if (is_android) {
« no previous file with comments | « no previous file | ui/compositor/BUILD.gn » ('j') | ui/events/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698