bluetooth: Implement FailingConnectionsAdapter.

content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 
 #include "base/callback.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 #include "device/bluetooth/test/mock_bluetooth_adapter.h"
 #include "device/bluetooth/test/mock_bluetooth_device.h"
 #include "device/bluetooth/test/mock_bluetooth_discovery_session.h"
 #include "device/bluetooth/test/mock_bluetooth_gatt_characteristic.h"
 #include "device/bluetooth/test/mock_bluetooth_gatt_service.h"
 
 namespace content {
 
 // Implements fake adapters with named mock data set for use in tests as a
 // result of layout tests calling testRunner.setBluetoothMockDataSet.
 
 // We have a complete “GenericAccessAdapter”, meaning it has a device which has
 // a Generic Access service with a Device Name characteristic with a descriptor.
 // The other adapters are named based on their particular non-expected behavior.
 
+// errorUUID note:
+// This algorithm consists of replacing the top 32 bits of
+// "00000000-97e5-4cd7-b9f1-f5a427670c59" with the bits of the alias.

[Jeffrey Yasskin, 2015/07/21 23:08:58]

You don't need the "The algorithm consists of" wording: that's in the Web BT
spec just so I can make the real definition be in the Bluetooth spec but still
give developers something to hold onto. Say something like:

errorUUID(alias), used below, returns a UUID with the top 32 bits of
"00000000-97e5-4cd7-b9f1-f5a427670c59" replaced with the bits of |alias|. For
example, errorUUID(0xDEADBEEF) returns "deadbeef-97e5-4cd7-b9f1-f5a427670c59".
The bottom 96 bits of error UUIDs were generated as a type 4 (random) UUID.

[ortuno, 2015/07/22 01:06:20]

Done.

+// For example, errorUUID(0xDEADBEEF) turns into
+// "deadbeef-97e5-4cd7-b9f1-f5a427670c59".
+
 class LayoutTestBluetoothAdapterProvider {
  public:
   // Returns a BluetoothAdapter. Its behavior depends on |fake_adapter_name|.
   static scoped_refptr<device::BluetoothAdapter> GetBluetoothAdapter(
       const std::string& fake_adapter_name);
 
  private:
   // Adapters
 
   // |BaseAdapter|
@@ skipping 61 matching lines @@
 
   // |MissingCharacteristicGenericAccessAdapter|
   // Inherits from EmptyAdapter
   // Internal Structure:
   //   - GenericAccessDevice
   //       - GenericAccess UUID (0x1800)
   //       - GenericAccessService
   static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
   GetMissingCharacteristicGenericAccessAdapter();
 
+  // |FailingConnectionsAdapter|
+  // Inherits from BaseAdapter
+  // FailingConnectionsAdapter holds a device for each type of connection error
+  // that can occur. This way we don’t need to create an adapter for each type
+  // of error. Each of the devices has a different UUID so that they can be

[Jeffrey Yasskin, 2015/07/21 23:08:58]

"has a service with a different UUID"

[ortuno, 2015/07/22 01:06:20]

Done.

+  // accessed by using different filters.
+  // See errorUUID note at the top for errorUUID() explanation.
+  // Internal Structure:
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_UNKNOWN)       errorUUID(0x0)

[Jeffrey Yasskin, 2015/07/21 23:08:58]

This set of error codes isn't going to generalize well to other browsers. I'm
not sure what we should do about that, since we do want to test all of our error
codes. Maybe we just mark certain tests as not upstreamable?

[Jeffrey Yasskin, 2015/07/21 23:09:33]

@scheib, thoughts?

[scheib, 2015/07/22 00:15:58]

In thinking over this, I agree, these tests have value, we should have them, and
test not only the error name but message as well.

It does not seem onerous to have other implementations produce the same errors
when under test. They may either hack the test suite to skip the tests, or they
may have a bit of code that when under test produces these error message in a
hard coded way. Imagine 
// Early respond to error for Bluetooth test suite devices that do not
// correspond to our implementation:
...

It's not so bad, especially since most of these will correspond to other
implementation's details too and they will use most of them.

I think go ahead with this and minimal modification. Comment in
LayoutTests/bluetooth/bluetooth-helpers.js connection_errors that these devices
correspond to a particular implementation's details and may not apply to all
implementations. 

[ortuno, 2015/07/22 01:06:20]

I think we are removing connection_errors. I will add a note in the tests
though.

+  //  - UnconnectableDevice(BluetoothDevice::ERROR_INPROGRESS)    errorUUID(0x1)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_FAILED)        errorUUID(0x2)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_AUTH_FAILED)   errorUUID(0x3)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_AUTH_CANCELED) errorUUID(0x4)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_AUTH_REJECTED) errorUUID(0x5)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_AUTH_TIMEOUT)  errorUUID(0x6)
+  //  - UnconnectableDevice(BluetoothDevice::ERROR_UNSUPPORTED_DEVICE)
+  //    errorUUID(0x7)
+  static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
+  GetFailingConnectionsAdapter();
+
   // Discovery Sessions
 
   // |DiscoverySession|
   // Mock Functions:
   //  - Stop:
   //      Run success callback.
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDiscoverySession>>
   GetDiscoverySession();
 
   // Devices
@@ skipping 76 matching lines @@
   // None.
   // Mock Functions:
   //   - CreateGattConnection:
   //       - Run success callback with BaseGATTConnection
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetConnectableDeviceNew(
       device::MockBluetoothAdapter* adapter,
       const std::string& device_name = "Connectable Device",
       device::BluetoothDevice::UUIDList = device::BluetoothDevice::UUIDList());
 
+  // |UnconnectableDevice|
+  // Inherits from BaseDevice(adapter, device_name)
+  // Adv UUIDs Added:
+  //  - uuid

[Jeffrey Yasskin, 2015/07/21 23:08:58]

'uuid' isn't one of the arguments.

[ortuno, 2015/07/22 01:06:20]

Done.

+  // Services Added:
+  // None.
+  // Mock Functions:
+  //  - CreateGATTConnection:
+  //      - Run error callback with error_type
+  static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
+  GetUnconnectableDevice(
+      device::MockBluetoothAdapter* adapter,
+      device::BluetoothDevice::ConnectErrorCode error_code,
+      const std::string& device_name = "Unconnectable Device");
+
   // |GenericAccessDevice|
   // Inherits from ConnectableDevice(adapter, device_name)
   // Adv UUIDs Added:
   //   - Generic Access UUID (0x1800)
   // Services Added:
   // None. Each user of the GenericAccessDevice is in charge of adding the
   // relevant services, characteristics, and descriptors.
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetGenericAccessDevice(
       device::MockBluetoothAdapter* adapter,
@@ skipping 95 matching lines @@
   // - |GetService| returns |service|.
   // - |IsNotifying| returns false.
   static scoped_ptr<testing::NiceMock<device::MockBluetoothGattCharacteristic>>
   GetGattCharacteristic(device::MockBluetoothGattService* service,
                         const std::string& uuid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_