Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: sdk/lib/io/platform_impl.dart

Issue 124753002: Code cleanup (mostly io lib and some http lib). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: integrate code review feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/platform_impl.dart
diff --git a/sdk/lib/io/platform_impl.dart b/sdk/lib/io/platform_impl.dart
index 40fe2f0cf79a7b557d2dfa1c3385262426fd1c19..c9383b18deb90b1fb9af4853f7cc95486f90729b 100644
--- a/sdk/lib/io/platform_impl.dart
+++ b/sdk/lib/io/platform_impl.dart
@@ -15,6 +15,9 @@ class _Platform {
external static String _packageRoot();
external static String _version();
+ static String executable = _executable();
+ static String packageRoot = _packageRoot();
+
static int get numberOfProcessors => _numberOfProcessors();
static String get pathSeparator => _pathSeparator();
static String get operatingSystem => _operatingSystem();
@@ -40,8 +43,6 @@ class _Platform {
}
}
- static String executable = _executable();
- static String packageRoot = _packageRoot();
static List<String> get executableArguments => _executableArguments();
static Map<String, String> get environment {
@@ -76,6 +77,8 @@ class _Platform {
// Environment variables are case-insensitive on Windows. In order
// to reflect that we use a case-insensitive string map on Windows.
class _CaseInsensitiveStringMap<V> implements Map<String, V> {
+ Map<String, V> _map;
+
_CaseInsensitiveStringMap() : _map = new Map<String, V>();
_CaseInsensitiveStringMap.from(Map<String, V> other)
@@ -105,6 +108,4 @@ class _CaseInsensitiveStringMap<V> implements Map<String, V> {
int get length => _map.length;
bool get isEmpty => _map.isEmpty;
bool get isNotEmpty => _map.isNotEmpty;
-
- Map<String, V> _map;
}

Powered by Google App Engine
This is Rietveld 408576698