Code cleanup (mostly io lib and some http lib).

sdk/lib/io/http_date.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 /**
  * Utility functions for working with dates with HTTP specific date
  * formats.
  */
@@ skipping 25 matching lines @@
    * Format a date according to
    * [RFC-1123](http://tools.ietf.org/html/rfc1123 "RFC-1123"),
    * e.g. `Thu, 1 Jan 1970 00:00:00 GMT`.
    */
   static String format(DateTime date) {
     const List wkday = const ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"];
     const List month = const ["Jan", "Feb", "Mar", "Apr", "May", "Jun",
                               "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"];
 
     DateTime d = date.toUtc();
-    StringBuffer sb = new StringBuffer();
-    sb.write(wkday[d.weekday - 1]);
-    sb.write(", ");
-    sb.write(d.day.toString());
-    sb.write(" ");
-    sb.write(month[d.month - 1]);
-    sb.write(" ");
-    sb.write(d.year.toString());
-    sb.write(d.hour < 9 ? " 0" : " ");
-    sb.write(d.hour.toString());
-    sb.write(d.minute < 9 ? ":0" : ":");
-    sb.write(d.minute.toString());
-    sb.write(d.second < 9 ? ":0" : ":");
-    sb.write(d.second.toString());
-    sb.write(" GMT");
+    StringBuffer sb = new StringBuffer()

[Ivan Posva, 2014/01/08 17:35:38]

Lasse,

Can you please explain the motivation of this kind of change? I am failing to
see the increase in readability, you are not saving a local variable declaration
and not saving any keystrokes.

Thanks,
-Ivan

+        ..write(wkday[d.weekday - 1])
+        ..write(", ")
+        ..write(d.day.toString())
+        ..write(" ")
+        ..write(month[d.month - 1])
+        ..write(" ")
+        ..write(d.year.toString())
+        ..write(d.hour < 9 ? " 0" : " ")
+        ..write(d.hour.toString())
+        ..write(d.minute < 9 ? ":0" : ":")
+        ..write(d.minute.toString())
+        ..write(d.second < 9 ? ":0" : ":")
+        ..write(d.second.toString())
+        ..write(" GMT");
     return sb.toString();
   }
 
   /**
    * Parse a date string in either of the formats
    * [RFC-1123](http://tools.ietf.org/html/rfc1123 "RFC-1123"),
    * [RFC-850](http://tools.ietf.org/html/rfc850 "RFC-850") or
    * ANSI C's asctime() format. These formats are listed here.
    *
    *     Thu, 1 Jan 1970 00:00:00 GMT
@@ skipping 137 matching lines @@
     const List monthsLowerCase = const ["jan", "feb", "mar", "apr", "may",
                                         "jun", "jul", "aug", "sep", "oct",
                                         "nov", "dec"];
 
     int position = 0;
 
     void error() {
       throw new HttpException("Invalid cookie date $date");
     }
 
-    bool isEnd() {
-      return position == date.length;
-    }
+    bool isEnd() => position == date.length;
 
     bool isDelimiter(String s) {
       int char = s.codeUnitAt(0);
       if (char == 0x09) return true;
       if (char >= 0x20 && char <= 0x2F) return true;
       if (char >= 0x3B && char <= 0x40) return true;
       if (char >= 0x5B && char <= 0x60) return true;
       if (char >= 0x7B && char <= 0x7E) return true;
       return false;
     }
@@ skipping 76 matching lines @@
     int hour = toInt(timeList[0]);
     int minute = toInt(timeList[1]);
     int second = toInt(timeList[2]);
     if (hour > 23) error();
     if (minute > 59) error();
     if (second > 59) error();
 
     return new DateTime.utc(year, month, dayOfMonth, hour, minute, second, 0);
   }
 }