Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: remoting/protocol/third_party_client_authenticator.h

Issue 12475020: Client plugin changes to support third party authentication. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: extraneous override Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/third_party_client_authenticator.h
diff --git a/remoting/protocol/third_party_client_authenticator.h b/remoting/protocol/third_party_client_authenticator.h
index 0827c171d3f9ff1815e2e122c32f9c0a379cb79c..696d8a670ce566a9c7276b98abfc193c3b6c5c8b 100644
--- a/remoting/protocol/third_party_client_authenticator.h
+++ b/remoting/protocol/third_party_client_authenticator.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "googleurl/src/gurl.h"
#include "remoting/protocol/third_party_authenticator_base.h"
class GURL;
@@ -49,15 +50,14 @@ class ThirdPartyClientAuthenticator : public ThirdPartyAuthenticatorBase {
// The request is canceled if the TokenFetcher is destroyed.
virtual void FetchThirdPartyToken(
const GURL& token_url,
- const std::string& host_public_key,
const std::string& scope,
const TokenFetchedCallback& token_fetched_callback) = 0;
};
// Creates a third-party client authenticator for the host with the given
// |host_public_key|. |token_fetcher| is used to get the authentication token.
- ThirdPartyClientAuthenticator(const std::string& host_public_key,
- scoped_ptr<TokenFetcher> token_fetcher);
+ explicit ThirdPartyClientAuthenticator(
+ scoped_ptr<TokenFetcher> token_fetcher);
virtual ~ThirdPartyClientAuthenticator();
protected:
@@ -72,7 +72,6 @@ class ThirdPartyClientAuthenticator : public ThirdPartyAuthenticatorBase {
const std::string& third_party_token,
const std::string& shared_secret);
- std::string host_public_key_;
std::string token_;
scoped_ptr<TokenFetcher> token_fetcher_;
« no previous file with comments | « remoting/protocol/third_party_authenticator_unittest.cc ('k') | remoting/protocol/third_party_client_authenticator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698