Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 12475016: Maintain API compatibility with older versions of V8. (Closed)

Created:
7 years, 9 months ago by danno
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Maintain API compatibility with older versions of V8. Revert "Allow recording individual samples in addition to the aggregated CPU profiles" Revert "Isolatify CPU profiler" Revert "Isolatify HeapProfiler" Revert "Deprecate HeapSnapshot type" Revert "Isolatify CPU profiler public API" Revert "MSVS compilation fix after r14006" Revert "Add methods to allow resuming execution after calling TerminateExecution()." R=jkummerow@chromium.org,mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+633 lines, -924 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 5 chunks +10 lines, -52 lines 0 comments Download
M include/v8-profiler.h View 12 chunks +28 lines, -107 lines 0 comments Download
M src/api.cc View 20 chunks +34 lines, -190 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/cpu-profiler.h View 1 chunk +58 lines, -45 lines 0 comments Download
M src/cpu-profiler.cc View 12 chunks +105 lines, -44 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/heap-profiler.h View 2 chunks +33 lines, -13 lines 0 comments Download
M src/heap-profiler.cc View 2 chunks +107 lines, -18 lines 0 comments Download
M src/heap-snapshot-generator.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M src/isolate.h View 5 chunks +5 lines, -6 lines 0 comments Download
M src/isolate.cc View 5 chunks +4 lines, -28 lines 0 comments Download
M src/log.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/log.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/platform-cygwin.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/profile-generator.h View 9 chunks +5 lines, -14 lines 0 comments Download
M src/profile-generator.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M src/profile-generator-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 5 chunks +84 lines, -83 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 65 chunks +96 lines, -134 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 7 chunks +13 lines, -100 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
7 years, 9 months ago (2013-03-21 14:40:41 UTC) #1
Jakob Kummerow
rubber-stamp LGTM (if it builds).
7 years, 9 months ago (2013-03-21 14:41:40 UTC) #2
danno
7 years, 9 months ago (2013-03-21 14:42:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14031 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698