Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1247493004: X87: Fix pushing of register in CallConstructStub outside frame. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix pushing of register in CallConstructStub outside frame. port 1f295980b7ac309dcef732088ae363722277a408 (r29787). original commit message: This fixes a recent regression where the register holding the original receiver was pushed onto the stack before the internal frame within the CallStubInRecordCallTarget helper was created. That in turn confused the stack walker when allocations in these stubs failed. BUG= Committed: https://crrev.com/5cdb1cee4b98614cadcae927cfec6518162045df Cr-Commit-Position: refs/heads/master@{#29828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -21 lines) Patch
M src/x87/code-stubs-x87.cc View 4 chunks +40 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-24 01:58:17 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-24 02:10:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247493004/1
5 years, 5 months ago (2015-07-24 03:54:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-24 06:19:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 06:19:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cdb1cee4b98614cadcae927cfec6518162045df
Cr-Commit-Position: refs/heads/master@{#29828}

Powered by Google App Engine
This is Rietveld 408576698