Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1247493003: Happy (belated) New Year, 2015 edition! (Closed)

Created:
5 years, 5 months ago by Matt Giuca
Modified:
5 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Happy (belated) New Year, 2015 edition! Committed: https://crrev.com/0125cf675617075bb4216dc1a794b9038be4f63d Cr-Commit-Position: refs/heads/master@{#340426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M LICENSE View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Matt Giuca
Incidentally, why is this file commented like a C++ file? Can we just remove that?
5 years, 5 months ago (2015-07-23 07:57:53 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm I assume the reason is because it can be readily copied and pasted. I ...
5 years, 5 months ago (2015-07-23 17:55:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247493003/1
5 years, 5 months ago (2015-07-23 23:55:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/95234) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 00:03:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247493003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247493003/1
5 years, 5 months ago (2015-07-27 03:57:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-27 07:03:44 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-27 07:04:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0125cf675617075bb4216dc1a794b9038be4f63d
Cr-Commit-Position: refs/heads/master@{#340426}

Powered by Google App Engine
This is Rietveld 408576698