Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1247443004: [es6] Some renamings and minor clean-ups in parameter parsing (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, caitp (gmail), Dan Ehrenberg
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Some renamings and minor clean-ups in parameter parsing In particular, rename FormalParameterParsingState and friends to FormalParameters etc. This should not change any logic, but is a preparatory CL for a bunch of follow-up fixes and clean-ups. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/dad797993c0bc0217be32f003238617907b1b28a Cr-Commit-Position: refs/heads/master@{#29807}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove accidental line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -136 lines) Patch
M src/parser.h View 8 chunks +37 lines, -38 lines 0 comments Download
M src/parser.cc View 1 17 chunks +33 lines, -44 lines 0 comments Download
M src/preparser.h View 21 chunks +44 lines, -46 lines 0 comments Download
M src/preparser.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
rossberg
5 years, 5 months ago (2015-07-23 10:50:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247443004/1
5 years, 5 months ago (2015-07-23 11:07:04 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/1247443004/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1247443004/diff/1/src/parser.cc#newcode4306 src/parser.cc:4306: if (parameters.has_rest) return false; This semantic change is ...
5 years, 5 months ago (2015-07-23 11:12:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7915)
5 years, 5 months ago (2015-07-23 11:17:25 UTC) #6
rossberg
https://codereview.chromium.org/1247443004/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1247443004/diff/1/src/parser.cc#newcode4306 src/parser.cc:4306: if (parameters.has_rest) return false; On 2015/07/23 11:12:48, Michael Starzinger ...
5 years, 5 months ago (2015-07-23 11:21:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247443004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247443004/20001
5 years, 5 months ago (2015-07-23 11:21:55 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-23 11:53:37 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 11:53:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dad797993c0bc0217be32f003238617907b1b28a
Cr-Commit-Position: refs/heads/master@{#29807}

Powered by Google App Engine
This is Rietveld 408576698