Issue 1247373002: Revert of Potential fix for browser crash while ChromeVox is on.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1247373002: Revert of Potential fix for browser crash while ChromeVox is on. (Closed)

Created:
5 years, 5 months ago by David Tseng

Modified:
5 years, 5 months ago

Reviewers:
dmazzoni, Peter Lundblad

CC:
chromium-reviews, sadrul, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Potential fix for browser crash while ChromeVox is on. (patchset #2 id:20001 of https://codereview.chromium.org/1245003002/) Reason for revert: Causing crash: crbug.com/512837 Original issue's description: > Potential fix for browser crash while ChromeVox is on. > > BUG=512000 > TEST=navigate to the launcher without and then with ChromeVox on. No crashes. > > Committed: https://crrev.com/22786b9f14a49d1bb0ddacbd9a9e343e482c23c9 > Cr-Commit-Position: refs/heads/master@{#339681} TBR=dmazzoni@chromium.org,plundblad@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512000 Committed: https://crrev.com/2d89f834dcf41424c1ef6a1f1f2326080a88e466 Cr-Commit-Position: refs/heads/master@{#339887}

Patch Set 1 #

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	chrome/browser/ui/aura/accessibility/automation_manager_aura.h	View		3 chunks	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/aura/accessibility/automation_manager_aura.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

David Tseng

Created Revert of Potential fix for browser crash while ChromeVox is on.

5 years, 5 months ago (2015-07-22 16:20:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247373002/1

5 years, 5 months ago (2015-07-22 16:20:45 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 16:22:06 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2d89f834dcf41424c1ef6a1f1f2326080a88e466
Cr-Commit-Position: refs/heads/master@{#339887}

Expand Messages | Collapse Messages