Complete implementation of bounds checking in the vm, by introducing a vm object

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 163 matching lines @@
   ASSERT(arguments.ArgCount() ==
          kAllocateObjectWithBoundsCheckRuntimeEntry.argument_count());
   const Class& cls = Class::CheckedHandle(arguments.ArgAt(0));
   const Instance& instance = Instance::Handle(Instance::New(cls));
   arguments.SetReturn(instance);
   ASSERT(cls.HasTypeArguments());
   AbstractTypeArguments& type_arguments =
       AbstractTypeArguments::CheckedHandle(arguments.ArgAt(1));
   ASSERT(type_arguments.IsNull() ||
          (type_arguments.Length() == cls.NumTypeArguments()));
-  AbstractTypeArguments& bounds_instantiator = AbstractTypeArguments::Handle();
   if (Object::Handle(arguments.ArgAt(2)).IsSmi()) {
     ASSERT(Smi::CheckedHandle(arguments.ArgAt(2)).Value() ==
            StubCode::kNoInstantiator);
   } else {
     ASSERT(!type_arguments.IsInstantiated());
     const AbstractTypeArguments& instantiator =
         AbstractTypeArguments::CheckedHandle(arguments.ArgAt(2));
     ASSERT(instantiator.IsNull() || instantiator.IsInstantiated());
+    Error& malformed_error = Error::Handle();
     if (instantiator.IsNull()) {
-      type_arguments =
-          InstantiatedTypeArguments::New(type_arguments, instantiator);
+      type_arguments = type_arguments.InstantiateFrom(instantiator,
+                                                      &malformed_error);
     } else if (instantiator.IsTypeArguments()) {
       // Code inlined in the caller should have optimized the case where the
       // instantiator is a TypeArguments and can be used as type argument
       // vector.
       ASSERT(!type_arguments.IsUninstantiatedIdentity() ||
              (instantiator.Length() != type_arguments.Length()));
-      type_arguments =
-          InstantiatedTypeArguments::New(type_arguments, instantiator);
+      type_arguments = type_arguments.InstantiateFrom(instantiator,
+                                                      &malformed_error);
     } else {
       // If possible, use the instantiator as the type argument vector.
       if (type_arguments.IsUninstantiatedIdentity() &&
           (instantiator.Length() == type_arguments.Length())) {
         type_arguments = instantiator.raw();
       } else {
-        type_arguments =
-            InstantiatedTypeArguments::New(type_arguments, instantiator);
+        type_arguments = type_arguments.InstantiateFrom(instantiator,
+                                                        &malformed_error);
       }
     }
-    bounds_instantiator = instantiator.raw();
-  }
-  if (!type_arguments.IsNull()) {
-    ASSERT(type_arguments.IsInstantiated());
-    Error& malformed_error = Error::Handle();
-    if (!type_arguments.IsWithinBoundsOf(cls,
-                                         bounds_instantiator,
-                                         &malformed_error)) {
-      ASSERT(!malformed_error.IsNull());
+    if (!malformed_error.IsNull()) {
       // Throw a dynamic type error.
       const intptr_t location = GetCallerLocation();
       String& malformed_error_message =  String::Handle(
           String::New(malformed_error.ToErrorCString()));
       Exceptions::CreateAndThrowTypeError(
           location, Symbols::Empty(), Symbols::Empty(),
           Symbols::Empty(), malformed_error_message);
       UNREACHABLE();
     }
   }
+  ASSERT(type_arguments.IsNull() || type_arguments.IsInstantiated());
   instance.SetTypeArguments(type_arguments);
 }
 
 
 // Instantiate type arguments.
 // Arg0: uninstantiated type arguments.
 // Arg1: instantiator type arguments.
 // Return value: instantiated type arguments.
 DEFINE_RUNTIME_ENTRY(InstantiateTypeArguments, 2) {
   ASSERT(arguments.ArgCount() ==
@@ skipping 123 matching lines @@
     OS::PrintErr("%s: '%s' %"Pd" %s '%s' %"Pd" (pc: %#"Px").\n",
                  message,
                  String::Handle(instance_type.Name()).ToCString(),
                  Class::Handle(instance_type.type_class()).id(),
                  (result.raw() == Bool::True().raw()) ? "is" : "is !",
                  String::Handle(type.Name()).ToCString(),
                  Class::Handle(type.type_class()).id(),
                  caller_frame->pc());
   } else {
     // Instantiate type before printing.
-    const AbstractType& instantiated_type =
-        AbstractType::Handle(type.InstantiateFrom(instantiator_type_arguments));
+    Error& malformed_error = Error::Handle();
+    const AbstractType& instantiated_type = AbstractType::Handle(
+        type.InstantiateFrom(instantiator_type_arguments, &malformed_error));
     OS::PrintErr("%s: '%s' %s '%s' instantiated from '%s' (pc: %#"Px").\n",
                  message,
                  String::Handle(instance_type.Name()).ToCString(),
                  (result.raw() == Bool::True().raw()) ? "is" : "is !",
                  String::Handle(instantiated_type.Name()).ToCString(),
                  String::Handle(type.Name()).ToCString(),
                  caller_frame->pc());
+    if (!malformed_error.IsNull()) {
+      OS::Print("  malformed error: %s\n", malformed_error.ToErrorCString());
+    }
   }
   const Function& function = Function::Handle(
       caller_frame->LookupDartFunction());
   OS::PrintErr(" -> Function %s\n", function.ToFullyQualifiedCString());
 }
 
 
 // Converts InstantiatedTypeArguments to TypeArguments and stores it
 // into the instance. The assembly code can handle only type arguments of
 // class TypeArguments. Because of the overhead, do it only when needed.
@@ skipping 11 matching lines @@
   bool replaced = false;
   if (type_arguments.IsInstantiatedTypeArguments()) {
     AbstractTypeArguments& uninstantiated = AbstractTypeArguments::Handle();
     AbstractTypeArguments& instantiator = AbstractTypeArguments::Handle();
     do {
       const InstantiatedTypeArguments& instantiated_type_arguments =
           InstantiatedTypeArguments::Cast(type_arguments);
       uninstantiated =
           instantiated_type_arguments.uninstantiated_type_arguments();
       instantiator = instantiated_type_arguments.instantiator_type_arguments();
-      type_arguments = uninstantiated.InstantiateFrom(instantiator);
+      Error& malformed_error = Error::Handle();
+      type_arguments = uninstantiated.InstantiateFrom(instantiator,
+                                                      &malformed_error);
+      ASSERT(malformed_error.IsNull());  // Malformed types are not optimized.
     } while (type_arguments.IsInstantiatedTypeArguments());
     AbstractTypeArguments& new_type_arguments = AbstractTypeArguments::Handle();
     new_type_arguments = type_arguments.Canonicalize();
     instance.SetTypeArguments(new_type_arguments);
     replaced = true;
   } else if (!type_arguments.IsCanonical()) {
     AbstractTypeArguments& new_type_arguments = AbstractTypeArguments::Handle();
     new_type_arguments = type_arguments.Canonicalize();
     instance.SetTypeArguments(new_type_arguments);
     replaced = true;
@@ skipping 82 matching lines @@
   }
   if (!instantiator_type_arguments.IsInstantiatedTypeArguments()) {
     new_cache.AddCheck(instance_class.id(),
                        instance_type_arguments,
                        instantiator_type_arguments,
                        result);
   }
   if (FLAG_trace_type_checks) {
     AbstractType& test_type = AbstractType::Handle(type.raw());
     if (!test_type.IsInstantiated()) {
-      test_type = type.InstantiateFrom(instantiator_type_arguments);
+      Error& malformed_error = Error::Handle();
+      test_type = type.InstantiateFrom(instantiator_type_arguments,
+                                       &malformed_error);
+      ASSERT(malformed_error.IsNull());  // Malformed types are not optimized.
     }
     OS::PrintErr("  Updated test cache %p ix: %"Pd" with (%"Pd", %p, %p, %s)\n"
         "    [%p %s %"Pd", %p %s]\n"
         "    [%p %s %"Pd", %p %s] %s\n",
         new_cache.raw(),
         len,
         instance_class.id(),
 
         instance_type_arguments.raw(),
         instantiator_type_arguments.raw(),
@@ skipping 94 matching lines @@
   }
   if (!is_instance_of) {
     // Throw a dynamic type error.
     const intptr_t location = GetCallerLocation();
     const AbstractType& src_type = AbstractType::Handle(src_instance.GetType());
     const String& src_type_name = String::Handle(src_type.UserVisibleName());
     String& dst_type_name = String::Handle();
     if (!dst_type.IsInstantiated()) {
       // Instantiate dst_type before reporting the error.
       const AbstractType& instantiated_dst_type = AbstractType::Handle(
-          dst_type.InstantiateFrom(instantiator_type_arguments));
+          dst_type.InstantiateFrom(instantiator_type_arguments, NULL));
+      // Note that instantiated_dst_type may be malformed.
       dst_type_name = instantiated_dst_type.UserVisibleName();
     } else {
       dst_type_name = dst_type.UserVisibleName();
     }
     String& malformed_error_message =  String::Handle();
     if (!malformed_error.IsNull()) {
       ASSERT(FLAG_enable_type_checks);
       malformed_error_message = String::New(malformed_error.ToErrorCString());
     }
     Exceptions::CreateAndThrowTypeError(location, src_type_name, dst_type_name,
@@ skipping 1078 matching lines @@
     if (right < 0) {
       remainder -= right;
     } else {
       remainder += right;
     }
   }
   return remainder;
 }
 
 }  // namespace dart