Source/modules/app_banner/AppBannerPromptResult.h - Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/AppBannerPromptResult.h

Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make prompt() return a new promise each call, and restore async callback registration. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/app_banner/AppBannerPromptResult.h

diff --git a/Source/modules/app_banner/AppBannerPromptResult.h b/Source/modules/app_banner/AppBannerPromptResult.h

index a949c7d086ae61e457d92f1a613c8417b724ee16..3ef287620e8e8efa53fb3f2824344e11a7f8a019 100644

--- a/Source/modules/app_banner/AppBannerPromptResult.h

+++ b/Source/modules/app_banner/AppBannerPromptResult.h

@@ -19,9 +19,7 @@ class AppBannerPromptResult final : public GarbageCollectedFinalized<AppBannerPr

DEFINE_WRAPPERTYPEINFO();

WTF_MAKE_NONCOPYABLE(AppBannerPromptResult);

public:

- // Support for CallbackPromiseAdapter:

- typedef blink::WebAppBannerPromptResult WebType;

- static AppBannerPromptResult* take(ScriptPromiseResolver*, PassOwnPtr<WebAppBannerPromptResult> webInstance);

+ static AppBannerPromptResult* take(PassOwnPtr<WebAppBannerPromptResult> webInstance);

static AppBannerPromptResult* create(const AtomicString& platform, WebAppBannerPromptResult::Outcome outcome)

{

« no previous file with comments | « Source/modules/app_banner/AppBannerController.cpp ('k') | Source/modules/app_banner/AppBannerPromptResult.cpp » ('j') | no next file with comments »