Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty

Source/modules/app_banner/BeforeInstallPromptEvent.h

Index: Source/modules/app_banner/BeforeInstallPromptEvent.h
diff --git a/Source/modules/app_banner/BeforeInstallPromptEvent.h b/Source/modules/app_banner/BeforeInstallPromptEvent.h
index a28d0a55b894c197f2977210271bf028b80185eb..1e9c558d1248bc0e2b638c7393fae2a33e7b0732 100644
--- a/Source/modules/app_banner/BeforeInstallPromptEvent.h
+++ b/Source/modules/app_banner/BeforeInstallPromptEvent.h
@@ -6,7 +6,9 @@
 #define BeforeInstallPromptEvent_h
 
 #include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseProperty.h"
 #include "modules/EventModules.h"
+#include "modules/app_banner/AppBannerPromptResult.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
@@ -25,9 +27,9 @@ public:
         return adoptRefWillBeNoop(new BeforeInstallPromptEvent());
     }
 
-    static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, const Vector<String>& platforms, int requestId, WebAppBannerClient*client)
+    static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, ScriptState* scriptState, const Vector<String>& platforms, int requestId, WebAppBannerClient* client)
     {
-        return adoptRefWillBeNoop(new BeforeInstallPromptEvent(name, platforms, requestId, client));
+        return adoptRefWillBeNoop(new BeforeInstallPromptEvent(name, scriptState, platforms, requestId, client));
     }
 
     static PassRefPtrWillBeRawPtr<BeforeInstallPromptEvent> create(const AtomicString& name, const BeforeInstallPromptEventInit& init)
@@ -37,22 +39,27 @@ public:
 
     Vector<String> platforms() const;
     ScriptPromise userChoice(ScriptState*);
+    ScriptPromise prompt(ScriptState*);
 
     const AtomicString& interfaceName() const override;
 
-    ScriptPromise prompt(ScriptState*);
+    void resolveUserChoice(AppBannerPromptResult*);
 

[yhirano, 2015/07/23 12:25:02]

+ trace

[dominickn, 2015/07/23 13:13:48]

Done.

 private:
     BeforeInstallPromptEvent();
-    BeforeInstallPromptEvent(const AtomicString& name, const Vector<String>& platforms, int requestId, WebAppBannerClient*);
+    BeforeInstallPromptEvent(const AtomicString& name, ScriptState*, const Vector<String>& platforms, int requestId, WebAppBannerClient*);
     BeforeInstallPromptEvent(const AtomicString& name, const BeforeInstallPromptEventInit&);
 
+    typedef ScriptPromiseProperty<RawPtrWillBeMember<BeforeInstallPromptEvent>, Member<AppBannerPromptResult>, ToV8UndefinedGenerator> UserChoiceProperty;
+    typedef ScriptPromiseProperty<RawPtrWillBeMember<BeforeInstallPromptEvent>, ToV8UndefinedGenerator, Member<DOMException>> PromptProperty;
+
     Vector<String> m_platforms;
-    ScriptPromise m_userChoice;
 
     int m_requestId;
     WebAppBannerClient* m_client;
     bool m_redispatched;
+    PersistentWillBeMember<UserChoiceProperty> m_userChoice;
+    PersistentWillBeMember<PromptProperty> m_prompt;
 };
 
 DEFINE_TYPE_CASTS(BeforeInstallPromptEvent, Event, event, event->interfaceName() == EventNames::BeforeInstallPromptEvent, event.interfaceName() == EventNames::BeforeInstallPromptEvent);