Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: Source/modules/app_banner/AppBannerController.cpp

Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make prompt() return a new promise each call, and restore async callback registration. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/app_banner/AppBannerController.h" 6 #include "modules/app_banner/AppBannerController.h"
7 7
8 #include "core/EventTypeNames.h" 8 #include "core/EventTypeNames.h"
9 #include "core/dom/Document.h"
9 #include "core/frame/DOMWindow.h" 10 #include "core/frame/DOMWindow.h"
10 #include "core/frame/LocalFrame.h" 11 #include "core/frame/LocalFrame.h"
11 #include "modules/app_banner/BeforeInstallPromptEvent.h" 12 #include "modules/app_banner/BeforeInstallPromptEvent.h"
12 #include "platform/RuntimeEnabledFeatures.h" 13 #include "platform/RuntimeEnabledFeatures.h"
13 #include "public/platform/WebVector.h" 14 #include "public/platform/WebVector.h"
15 #include "public/platform/modules/app_banner/WebAppBannerClient.h"
14 #include "public/platform/modules/app_banner/WebAppBannerPromptReply.h" 16 #include "public/platform/modules/app_banner/WebAppBannerPromptReply.h"
15 17
16 namespace blink { 18 namespace blink {
17 19
18 // static 20 // static
19 void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne rClient* client, LocalFrame* frame, const WebVector<WebString>& platforms, WebAp pBannerPromptReply* reply) 21 void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBanne rClient* client, LocalFrame* frame, const WebVector<WebString>& platforms, WebAp pBannerPromptReply* reply)
20 { 22 {
21 ASSERT(RuntimeEnabledFeatures::appBannerEnabled()); 23 ASSERT(RuntimeEnabledFeatures::appBannerEnabled());
22 24
23 Vector<String> wtfPlatforms; 25 Vector<String> wtfPlatforms;
24 for (const WebString& platform : platforms) 26 for (const WebString& platform : platforms)
25 wtfPlatforms.append(platform); 27 wtfPlatforms.append(platform);
26 28
27 // dispatchEvent() returns whether the default behavior can happen. In other 29 // dispatchEvent() returns whether the default behavior can happen. In other
28 // words, it returns false if preventDefault() was called. 30 // words, it returns false if preventDefault() was called.
29 *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create( EventTypeNames::beforeinstallprompt, wtfPlatforms, requestId, client)) 31 *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create( EventTypeNames::beforeinstallprompt, frame->document(), wtfPlatforms, requestId, client))
30 ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel; 32 ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel;
31 } 33 }
32 34
33 } // namespace blink 35 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/app_banner/AppBannerCallbacks.cpp ('k') | Source/modules/app_banner/AppBannerPromptResult.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698