Source/modules/app_banner/AppBannerCallbacks.cpp - Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/app_banner/AppBannerCallbacks.cpp

Issue 1247283004: Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Replace typedef with using as per style guide Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/app_banner/AppBannerCallbacks.h ('K') | « Source/modules/app_banner/AppBannerCallbacks.h ('k') | Source/modules/app_banner/AppBannerController.cpp » ('j') | Source/modules/app_banner/AppBannerPromptResult.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "modules/app_banner/AppBannerCallbacks.h"

	7

	8 namespace blink {

	9

	10 AppBannerCallbacks::AppBannerCallbacks(UserChoiceProperty* userChoice)

	11 : m_userChoice(userChoice)

	12 {

	13 }

	14

	15 void AppBannerCallbacks::onSuccess(WebAppBannerPromptResult* result)

	16 {

	17 OwnPtr<WebAppBannerPromptResult> ownPtr = adoptPtr(result);

	18 m_userChoice->resolve(AppBannerPromptResult::take(ownPtr.release()));
	mlamouri (slow - plz ping) 2015/07/24 15:08:25 There is no way to do that in one line? (ie. not h There is no way to do that in one line? (ie. not have to create an OwnPtr<> on the stack in order to pass a PassOwnPtr<>? dominickn 2015/07/24 23:53:35 Done. Show quoted text On 2015/07/24 15:08:25, Mounir Lamouri wrote: > There is no way to do that in one line? (ie. not have to create an OwnPtr<> on > the stack in order to pass a PassOwnPtr<>? Done.
	19 }

	20

	21 } // namespace blink

OLD	NEW