Refactor BeforeInstallPromptEvent to use ScriptPromiseProperty

Source/modules/app_banner/AppBannerController.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/app_banner/AppBannerController.h"
 
+#include "bindings/core/v8/ScriptController.h"
+#include "bindings/core/v8/ScriptState.h"
 #include "core/EventTypeNames.h"
 #include "core/frame/DOMWindow.h"
 #include "core/frame/LocalFrame.h"
+#include "modules/app_banner/AppBannerCallbacks.h"
 #include "modules/app_banner/BeforeInstallPromptEvent.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "public/platform/WebVector.h"
+#include "public/platform/modules/app_banner/WebAppBannerClient.h"
 #include "public/platform/modules/app_banner/WebAppBannerPromptReply.h"
 
 namespace blink {
 
 // static
 void AppBannerController::willShowInstallBannerPrompt(int requestId, WebAppBannerClient* client, LocalFrame* frame, const WebVector<WebString>& platforms, WebAppBannerPromptReply* reply)
 {
     ASSERT(RuntimeEnabledFeatures::appBannerEnabled());
 
     Vector<String> wtfPlatforms;
     for (const WebString& platform : platforms)
         wtfPlatforms.append(platform);
 
+    ScriptState* scriptState = ScriptState::forMainWorld(frame);
+    ScriptState::Scope scope(scriptState);
+    RefPtrWillBeRawPtr<BeforeInstallPromptEvent> event = BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, scriptState, wtfPlatforms, requestId, client);

[yhirano, 2015/07/23 12:25:02]

IIUC You don't need ScriptState. You only need ExecutionContext.

[dominickn, 2015/07/23 13:13:48]

Done.

[yhirano, 2015/07/24 03:41:16]

You can use frame->document() if it is the right ExecutionContext.

[dominickn, 2015/07/24 05:02:09]

Done.

+    WebAppBannerCallbacks* callbacks = new AppBannerCallbacks(event.get());
+    client->registerBannerCallbacks(requestId, callbacks);
+
     // dispatchEvent() returns whether the default behavior can happen. In other
     // words, it returns false if preventDefault() was called.
-    *reply = frame->domWindow()->dispatchEvent(BeforeInstallPromptEvent::create(EventTypeNames::beforeinstallprompt, wtfPlatforms, requestId, client))
+    *reply = frame->domWindow()->dispatchEvent(event)
         ? WebAppBannerPromptReply::None : WebAppBannerPromptReply::Cancel;
 }
 
 } // namespace blink