Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1247233002: Revert of gpu: Use shader cache on ES3 (Closed)

Created:
5 years, 5 months ago by no sievers
Modified:
5 years, 5 months ago
Reviewers:
Zhenyao Mo, David Yen
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: Use shader cache on ES3 (patchset #2 id:20001 of https://codereview.chromium.org/1223393003/) Reason for revert: This codepath is actually flaky. OnLoadedShader() races with dynamic GL binding initialization. Previously it meant that we just might not end up loading this shader (as long as b_GL_OES_get_program_binary etc. default to false), but the GetGLVersionInfo() might actually crash. Original issue's description: > gpu: Use shader cache on ES3 > > The ES3 core specs supports gl(Get)ProgramBinary(). > BUG=510172 > > Committed: https://crrev.com/809d9b979c0edd3976132eaaf77fc4740fcee019 > Cr-Commit-Position: refs/heads/master@{#339369} TBR=dyen@chromium.org,zmo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=510172, 512464 Committed: https://crrev.com/ee93fe24ade72f695c5873b182b0b1774f223b6c Cr-Commit-Position: refs/heads/master@{#339802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
no sievers
Created Revert of gpu: Use shader cache on ES3
5 years, 5 months ago (2015-07-22 00:46:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247233002/1
5 years, 5 months ago (2015-07-22 00:47:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 00:50:34 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 00:51:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee93fe24ade72f695c5873b182b0b1774f223b6c
Cr-Commit-Position: refs/heads/master@{#339802}

Powered by Google App Engine
This is Rietveld 408576698