Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: chrome/browser/android/dev_tools_server.cc

Issue 12472004: Provide DevToolsHttpHandlerDelegate with an ability to provide additional page info (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Hopefully, cover all delegate implementations Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/dev_tools_server.cc
diff --git a/chrome/browser/android/dev_tools_server.cc b/chrome/browser/android/dev_tools_server.cc
index 2dce4ea16de874bc80be81b81151bde964e2b108..8af312467f8842b3a2b4208578bd1ff5820184bc 100644
--- a/chrome/browser/android/dev_tools_server.cc
+++ b/chrome/browser/android/dev_tools_server.cc
@@ -41,7 +41,7 @@ class DevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate {
: use_bundled_frontend_resources_(use_bundled_frontend_resources) {
}
- virtual std::string GetDiscoveryPageHTML() {
+ virtual std::string GetDiscoveryPageHTML() OVERRIDE {
// TopSites updates itself after a delay. Ask TopSites to update itself
// when we're about to show the remote debugging landing page.
content::BrowserThread::PostTask(
@@ -52,15 +52,15 @@ class DevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate {
IDR_DEVTOOLS_DISCOVERY_PAGE_HTML).as_string();
}
- virtual bool BundlesFrontendResources() {
+ virtual bool BundlesFrontendResources() OVERRIDE {
return use_bundled_frontend_resources_;
}
- virtual base::FilePath GetDebugFrontendDir() {
+ virtual base::FilePath GetDebugFrontendDir() OVERRIDE {
return base::FilePath();
}
- virtual std::string GetPageThumbnailData(const GURL& url) {
+ virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {
Profile* profile =
ProfileManager::GetLastUsedProfile()->GetOriginalProfile();
history::TopSites* top_sites = profile->GetTopSites();
@@ -73,14 +73,18 @@ class DevToolsServerDelegate : public content::DevToolsHttpHandlerDelegate {
return "";
}
- content::RenderViewHost* CreateNewTarget() {
+ virtual content::RenderViewHost* CreateNewTarget() OVERRIDE {
return NULL;
}
- TargetType GetTargetType(content::RenderViewHost*) {
+ virtual TargetType GetTargetType(content::RenderViewHost*) OVERRIDE {
return kTargetTypeTab;
}
+ virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE {
+ return "";
+ }
+
private:
static void PopulatePageThumbnails() {
Profile* profile =
« no previous file with comments | « android_webview/browser/aw_devtools_delegate.cc ('k') | chrome/browser/devtools/browser_list_tabcontents_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698