Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1247163002: Migrate SiteSettingsPreferencesTest from ChromeShell to ChromePublic. (Closed)

Created:
5 years, 5 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate SiteSettingsPreferencesTest from ChromeShell to ChromePublic. BUG=505040 Committed: https://crrev.com/045efe8c9d2ac6bfffd1d1fd31f735b4edb0dab6 Cr-Commit-Position: refs/heads/master@{#339789}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -456 lines) Patch
A + chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java View 1 11 chunks +29 lines, -36 lines 0 comments Download
D chrome/android/javatests_shell/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java View 1 chunk +0 lines, -420 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 5 months ago (2015-07-21 22:54:00 UTC) #2
gone
lgtm
5 years, 5 months ago (2015-07-21 22:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247163002/20001
5 years, 5 months ago (2015-07-21 22:58:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 00:06:42 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 00:08:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/045efe8c9d2ac6bfffd1d1fd31f735b4edb0dab6
Cr-Commit-Position: refs/heads/master@{#339789}

Powered by Google App Engine
This is Rietveld 408576698