Adding BrowsingDataPartitionClient

Adding BrowsingDataPartitionClient

This client informs embedders when a
BrowsingDataPartition becomes synchronized.

BUG=480654
Committed: https://crrev.com/e04c2db5c1b8cc89138544616b05dfeee53ae90f
Cr-Commit-Position: refs/heads/master@{#339770}

[shreyasv1, 2015-07-21 21:39:38]

shreyasv@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-07-21 21:48:03]

lgtm

https://codereview.chromium.org/1247143002/diff/1/ios/web/browsing_data_parti...
File ios/web/browsing_data_partition_impl.mm (right):

https://codereview.chromium.org/1247143002/diff/1/ios/web/browsing_data_parti...
ios/web/browsing_data_partition_impl.mm:88: web::BrowsingDataPartitionClient*
client =
NIT: Please either use auto or inline web::GetBrowsingDataPartitionClient()
call. This linebreak does not look very well. I would personally go with
inlining web::GetBrowsingDataPartitionClient() call, but it's up to you.

https://codereview.chromium.org/1247143002/diff/1/ios/web/public/browsing_dat...
File ios/web/public/browsing_data_partition_client.cc (right):

https://codereview.chromium.org/1247143002/diff/1/ios/web/public/browsing_dat...
ios/web/public/browsing_data_partition_client.cc:9: static
BrowsingDataPartitionClient* g_client;
We don't use static keyword for globals in Chromium. Please put g_client into an
anonymous namespace instead,

[shreyasv1, 2015-07-21 22:12:06]

https://codereview.chromium.org/1247143002/diff/1/ios/web/browsing_data_parti...
File ios/web/browsing_data_partition_impl.mm (right):

https://codereview.chromium.org/1247143002/diff/1/ios/web/browsing_data_parti...
ios/web/browsing_data_partition_impl.mm:88: web::BrowsingDataPartitionClient*
client =
On 2015/07/21 21:48:03, eugenebut wrote:
> NIT: Please either use auto or inline web::GetBrowsingDataPartitionClient()
> call. This linebreak does not look very well. I would personally go with
> inlining web::GetBrowsingDataPartitionClient() call, but it's up to you.

Acknowledged.

https://codereview.chromium.org/1247143002/diff/1/ios/web/public/browsing_dat...
File ios/web/public/browsing_data_partition_client.cc (right):

https://codereview.chromium.org/1247143002/diff/1/ios/web/public/browsing_dat...
ios/web/public/browsing_data_partition_client.cc:9: static
BrowsingDataPartitionClient* g_client;
On 2015/07/21 21:48:03, eugenebut wrote:
> We don't use static keyword for globals in Chromium. Please put g_client into
an
> anonymous namespace instead,

Good catch.

[shreyasv1, 2015-07-21 22:12:19]

The CQ bit was checked by shreyasv@chromium.org

[shreyasv1, 2015-07-21 22:12:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1247143002/#ps20001
(title: "y")

[commit-bot: I haz the power, 2015-07-21 22:13:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1247143002/20001

[commit-bot: I haz the power, 2015-07-21 22:38:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-21 22:39:59]

Patchset 2 (id:??) landed as
https://crrev.com/e04c2db5c1b8cc89138544616b05dfeee53ae90f
Cr-Commit-Position: refs/heads/master@{#339770}