Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

Issue 1247063007: Expect two tabs in StartupSupervisedUserProfile test on Windows 10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restore comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
index bbfb604470af57542d1bfd02f8dab3e344b8f220..a97c25a4390b1340f5a9f52240524e32d40b2e33 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
@@ -1187,8 +1187,11 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserBrowserCreatorTest,
ASSERT_TRUE(new_browser);
TabStripModel* tab_strip = new_browser->tab_strip_model();
- // There should be only one tab.
- EXPECT_EQ(1, tab_strip->count());
+ // There should be only one tab, except on Windows 10. See crbug.com/505029.
+ if (IsWindows10OrNewer())
msw 2015/07/21 23:14:35 nit: consider: const size_t tab_count = IsWindow
Will Harris 2015/07/21 23:21:08 Done. TabStripModel::count() returns a signed int
+ EXPECT_EQ(2, tab_strip->count());
+ else
+ EXPECT_EQ(1, tab_strip->count());
}
#endif // !defined(OS_CHROMEOS)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698