Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 1247063004: Unwind fastradio experiment. (Closed)

Created:
5 years, 5 months ago by davidben
Modified:
5 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unwind fastradio experiment. The experiment gave mixed results and is being dropped. Remove the code supporting it. BUG=none Committed: https://crrev.com/1de60e7fea00b6a685e032006ccf933351d557d8 Cr-Commit-Position: refs/heads/master@{#339748}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -57 lines) Patch
M chrome/browser/net/ssl_config_service_manager_pref.cc View 4 chunks +0 lines, -19 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/ssl/ssl_config.h View 1 chunk +0 lines, -10 lines 0 comments Download
M net/ssl/ssl_config.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/ssl/ssl_config_service.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/ssl/ssl_config_service.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
davidben
The relevant person at Google doesn't seem to be in codereview.chromium.org. I'll ping them on ...
5 years, 5 months ago (2015-07-21 19:32:41 UTC) #2
fenglu
On 2015/07/21 19:32:41, David Benjamin wrote: > The relevant person at Google doesn't seem to ...
5 years, 5 months ago (2015-07-21 20:08:30 UTC) #3
Ryan Sleevi
LGTM. Huge, huge thanks for cleaning this up.
5 years, 5 months ago (2015-07-21 20:55:04 UTC) #4
davidben
+asvitkine for histograms.xml
5 years, 5 months ago (2015-07-21 21:00:13 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 5 months ago (2015-07-21 21:00:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247063004/1
5 years, 5 months ago (2015-07-21 21:04:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 21:12:36 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 21:14:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1de60e7fea00b6a685e032006ccf933351d557d8
Cr-Commit-Position: refs/heads/master@{#339748}

Powered by Google App Engine
This is Rietveld 408576698