Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1247053002: Move GET_ACCOUNTS permission check to AccountManagerDelegate (Closed)

Created:
5 years, 5 months ago by nyquist
Modified:
5 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GET_ACCOUNTS permission check to AccountManagerDelegate Currently the AccountManagerHelper always checks the GET_ACCOUNTS permission. This should instead be done directly by the AccountManagerDelegate. BUG=509826 Committed: https://crrev.com/8fa468ef1d57bf34a0fd81c33a8866536e04f58a Cr-Commit-Position: refs/heads/master@{#339710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sync/android/java/src/org/chromium/sync/signin/AccountManagerHelper.java View 1 chunk +0 lines, -1 line 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/SystemAccountManagerDelegate.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nyquist
tedchoc: PTAL
5 years, 5 months ago (2015-07-21 18:10:34 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247053002/1
5 years, 5 months ago (2015-07-21 18:11:32 UTC) #4
Ted C
lgtm
5 years, 5 months ago (2015-07-21 18:38:11 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 18:51:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247053002/1
5 years, 5 months ago (2015-07-21 18:53:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:01:09 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:02:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fa468ef1d57bf34a0fd81c33a8866536e04f58a
Cr-Commit-Position: refs/heads/master@{#339710}

Powered by Google App Engine
This is Rietveld 408576698