Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1247033008: Update straggling ImageSource references (Closed)

Created:
5 years, 5 months ago by scroggo_chromium
Modified:
5 years, 3 months ago
Reviewers:
tkent, scroggo, Noel Gordon
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update straggling ImageSource references GIFImageReader no longer needs ImageSource to compile, so stop including it. Update ImageDecodeBench to use the enums in ImageDecoder, so it can build once again. These were missed in crrev.com/1242023004 No change in behavior, no new tests. BUG=439655 Committed: https://crrev.com/322d253ac9989e6020f69ed96ddb1d71e61cdb9e git-svn-id: svn://svn.chromium.org/blink/trunk@199491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Messages

Total messages: 15 (5 generated)
scroggo_chromium
5 years, 5 months ago (2015-07-23 20:17:38 UTC) #2
Noel Gordon
LGTM
5 years, 5 months ago (2015-07-24 02:16:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247033008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247033008/1
5 years, 5 months ago (2015-07-24 15:14:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/38440)
5 years, 5 months ago (2015-07-24 15:18:55 UTC) #7
scroggo_chromium
Can I get an OWNERS review?
5 years, 5 months ago (2015-07-24 16:02:31 UTC) #9
scroggo_chromium
On 2015/07/24 16:02:31, scroggo_chromium wrote: > Can I get an OWNERS review? (for Source/web)
5 years, 5 months ago (2015-07-24 16:02:42 UTC) #10
tkent
lgtm
5 years, 5 months ago (2015-07-26 23:42:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247033008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1247033008/1
5 years, 5 months ago (2015-07-26 23:42:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199491
5 years, 4 months ago (2015-07-27 07:12:34 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:47:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/322d253ac9989e6020f69ed96ddb1d71e61cdb9e

Powered by Google App Engine
This is Rietveld 408576698