Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3677)

Unified Diff: cc/trees/single_thread_proxy.cc

Issue 1247033007: cc: Abort frame when becoming invisible and waiting for ready to draw. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove race from test Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/single_thread_proxy.cc
diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_proxy.cc
index 0da42e5060b0199cd305e6e969d6b2ecd1587e44..f6e58105994c07f23e1594df6b27947503c57e0a 100644
--- a/cc/trees/single_thread_proxy.cc
+++ b/cc/trees/single_thread_proxy.cc
@@ -123,7 +123,9 @@ void SingleThreadProxy::SetLayerTreeHostClientReady() {
void SingleThreadProxy::SetVisible(bool visible) {
TRACE_EVENT1("cc", "SingleThreadProxy::SetVisible", "visible", visible);
DebugScopedSetImplThread impl(this);
+
layer_tree_host_impl_->SetVisible(visible);
+
if (scheduler_on_impl_thread_)
scheduler_on_impl_thread_->SetVisible(layer_tree_host_impl_->visible());
// Changing visibility could change ShouldComposite().
@@ -448,11 +450,6 @@ void SingleThreadProxy::PostAnimationEventsToMainThreadOnImplThread(
bool SingleThreadProxy::IsInsideDraw() { return inside_draw_; }
void SingleThreadProxy::DidActivateSyncTree() {
- // This is required because NotifyReadyToActivate gets called immediately
- // after commit since single thread commits directly to the active tree.
- if (scheduler_on_impl_thread_)
- scheduler_on_impl_thread_->SetWaitForReadyToDraw();
-
// Synchronously call to CommitComplete. Resetting
// |commit_blocking_task_runner| would make sure all tasks posted during
// commit/activation before CommitComplete.
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | tools/valgrind/gtest_exclude/cc_unittests.gtest-drmemory_win32.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698