Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1247023002: Revert of Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+ (Closed)

Created:
5 years, 5 months ago by michaelbai
Modified:
5 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, Mark Mentovai, cjhopman, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+ (patchset #2 id:20001 of https://codereview.chromium.org/1241333002/) Reason for revert: This patch broke the mips builder for Android ../../third_party/lss/linux_syscall_support.h:121:21: fatal error: sgidefs.h: No such file or directory #include <sgidefs.h> Original issue's description: > Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+ > > On Android L+, signal and sigaction symbols are provided by libsigchain > that override the system's versions. There is a bug in these functions > where they essentially ignore requests to install SIG_DFL. This causes > ProcessUtilTest.GetTerminationStatusCrash to fail (as > CrashingChildProcess goes into infinite loop instead of crashing). > > Workaround this issue by explicitly performing a syscall to > __NR_rt_sigaction to install SIG_DFL on Android, as breakpad does > (see https://breakpad.appspot.com/1804002/). > > BUG=512255 > TEST=ProcessUtilTest.GetTerminationStatusCrash > > Committed: https://crrev.com/31510fe3e2d3b1f3123f391db52372b2506c46ca > Cr-Commit-Position: refs/heads/master@{#339584} TBR=thakis@chromium.org,primiano@chromium.org,cullinan@amazon.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=512255 Committed: https://crrev.com/92f94f2028d3c226577930cb6df777f7f5edbbed Cr-Commit-Position: refs/heads/master@{#339668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M base/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process_util_unittest.cc View 2 chunks +1 line, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaelbai
Created Revert of Fix ProcessUtilTest.GetTerminationStatusCrash on Android L+
5 years, 5 months ago (2015-07-21 16:57:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1247023002/1
5 years, 5 months ago (2015-07-21 16:58:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 16:59:17 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:00:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92f94f2028d3c226577930cb6df777f7f5edbbed
Cr-Commit-Position: refs/heads/master@{#339668}

Powered by Google App Engine
This is Rietveld 408576698